You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by ho...@apache.org on 2024/05/22 07:20:53 UTC
(incubator-gluten) branch main updated: [GLUTEN-5837][VL] Fix duplicated projection name during substrait GenerateRel conversion (#5838)
This is an automated email from the ASF dual-hosted git repository.
hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new d966ea7f4 [GLUTEN-5837][VL] Fix duplicated projection name during substrait GenerateRel conversion (#5838)
d966ea7f4 is described below
commit d966ea7f4ad86aa4a974f3fa71269e8c2ba385e6
Author: James Xu <xu...@gmail.com>
AuthorDate: Wed May 22 15:20:48 2024 +0800
[GLUTEN-5837][VL] Fix duplicated projection name during substrait GenerateRel conversion (#5838)
---
cpp/velox/substrait/SubstraitToVeloxPlan.cc | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/cpp/velox/substrait/SubstraitToVeloxPlan.cc b/cpp/velox/substrait/SubstraitToVeloxPlan.cc
index c07826f5a..236203066 100644
--- a/cpp/velox/substrait/SubstraitToVeloxPlan.cc
+++ b/cpp/velox/substrait/SubstraitToVeloxPlan.cc
@@ -794,15 +794,14 @@ core::PlanNodePtr SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
unnest.emplace_back(unnestFieldExpr);
}
- // TODO(yuan): get from generator output
std::vector<std::string> unnestNames;
int unnestIndex = 0;
for (const auto& variable : unnest) {
if (variable->type()->isArray()) {
- unnestNames.emplace_back(fmt::format("C{}", unnestIndex++));
+ unnestNames.emplace_back(SubstraitParser::makeNodeName(planNodeId_, unnestIndex++));
} else if (variable->type()->isMap()) {
- unnestNames.emplace_back(fmt::format("C{}", unnestIndex++));
- unnestNames.emplace_back(fmt::format("C{}", unnestIndex++));
+ unnestNames.emplace_back(SubstraitParser::makeNodeName(planNodeId_, unnestIndex++));
+ unnestNames.emplace_back(SubstraitParser::makeNodeName(planNodeId_, unnestIndex++));
} else {
VELOX_FAIL(
"Unexpected type of unnest variable. Expected ARRAY or MAP, but got {}.", variable->type()->toString());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org