You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/05/06 03:39:56 UTC
[GitHub] [phoenix] stoty commented on pull request #1211: PHOENIX-6432 Add support for additional load generators
stoty commented on pull request #1211:
URL: https://github.com/apache/phoenix/pull/1211#issuecomment-833200850
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 14s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 25 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 29m 28s | 4.x passed |
| +1 :green_heart: | compile | 0m 49s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 38s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 22s | 4.x passed |
| +0 :ok: | spotbugs | 1m 15s | phoenix-pherf in 4.x has 51 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 23s | the patch passed |
| +1 :green_heart: | compile | 0m 46s | the patch passed |
| +1 :green_heart: | javac | 0m 46s | the patch passed |
| -1 :x: | checkstyle | 0m 41s | phoenix-pherf: The patch generated 533 new + 758 unchanged - 285 fixed = 1291 total (was 1043) |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | xml | 0m 12s | The patch has no ill-formed XML file. |
| -1 :x: | javadoc | 0m 22s | phoenix-pherf generated 25 new + 33 unchanged - 24 fixed = 58 total (was 57) |
| -1 :x: | spotbugs | 1m 30s | phoenix-pherf generated 12 new + 42 unchanged - 9 fixed = 54 total (was 51) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 11m 49s | phoenix-pherf in the patch passed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| | | 61m 0s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-pherf |
| | Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:[line 76] |
| | Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At RendezvousingWorkHandler.java:but method has no side effect At RendezvousingWorkHandler.java:[line 83] |
| | Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:[line 65] |
| | Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At TenantOperationWorkHandler.java:but method has no side effect At TenantOperationWorkHandler.java:[line 67] |
| | input must be non-null but is marked as nullable At IdleTimeOperationSupplier.java:is marked as nullable At IdleTimeOperationSupplier.java:[lines 51-74] |
| | input must be non-null but is marked as nullable At PreScenarioOperationSupplier.java:is marked as nullable At PreScenarioOperationSupplier.java:[lines 51-85] |
| | A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:[line 74] |
| | input must be non-null but is marked as nullable At QueryOperationSupplier.java:is marked as nullable At QueryOperationSupplier.java:[lines 54-94] |
| | Impossible cast from RuntimeException to java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:[line 351] |
| | input must be non-null but is marked as nullable At UpsertOperationSupplier.java:is marked as nullable At UpsertOperationSupplier.java:[lines 58-161] |
| | org.apache.phoenix.pherf.workload.mt.operations.UpsertOperationSupplier$1.apply(TenantOperationInfo) may fail to clean up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:[line 107] is not discharged |
| | input must be non-null but is marked as nullable At UserDefinedOperationSupplier.java:is marked as nullable At UserDefinedOperationSupplier.java:[lines 43-47] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1211 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle |
| uname | Linux 66c52231d33b 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / aacab94 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-general-check/output/whitespace-tabs.txt |
| javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-pherf.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1211/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1211/2/testReport/ |
| Max. process+thread count | 2207 (vs. ulimit of 30000) |
| modules | C: phoenix-pherf U: phoenix-pherf |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1211/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org