You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "whbing (via GitHub)" <gi...@apache.org> on 2023/02/09 05:11:33 UTC

[GitHub] [ozone] whbing opened a new pull request, #4262: HDDS-4223. Optimize the construction method of OzoneVolume and OzoneBucket.

whbing opened a new pull request, #4262:
URL: https://github.com/apache/ozone/pull/4262

   ## What changes were proposed in this pull request?
   
   Optimize the construction method of OzoneVolume and OzoneBucket.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4223
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] Galsza commented on pull request #4262: HDDS-4223. Optimize the construction method of OzoneVolume and OzoneBucket.

Posted by "Galsza (via GitHub)" <gi...@apache.org>.
Galsza commented on PR #4262:
URL: https://github.com/apache/ozone/pull/4262#issuecomment-1423917739

   Thanks for working on this patch, it is looking good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] captainzmc merged pull request #4262: HDDS-4223. Optimize the construction method of OzoneVolume and OzoneBucket.

Posted by "captainzmc (via GitHub)" <gi...@apache.org>.
captainzmc merged PR #4262:
URL: https://github.com/apache/ozone/pull/4262


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] whbing commented on a diff in pull request #4262: HDDS-4223. Optimize the construction method of OzoneVolume and OzoneBucket.

Posted by "whbing (via GitHub)" <gi...@apache.org>.
whbing commented on code in PR #4262:
URL: https://github.com/apache/ozone/pull/4262#discussion_r1101080659


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java:
##########
@@ -1034,6 +889,135 @@ public boolean setOwner(String userName) throws IOException {
     return result;
   }
 
+  public static Builder newBuilder(ConfigurationSource conf,
+      ClientProtocol proxy) {
+    Preconditions.checkNotNull(proxy, "Client proxy is not set.");
+    return new Builder(conf, proxy);
+  }
+
+  /**
+   * Inner builder for OzoneBucket.
+   */
+  public static class Builder {
+    private Map<String, String> metadata;
+    private ConfigurationSource conf;
+    private ClientProtocol proxy;
+    private String volumeName;
+    private String name;
+    private DefaultReplicationConfig defaultReplicationConfig;

Review Comment:
   Note: The `DefaultReplicationConfig` type from the original constructor is retained. `ReplicationConfig` is also available.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on pull request #4262: HDDS-4223. Optimize the construction method of OzoneVolume and OzoneBucket.

Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #4262:
URL: https://github.com/apache/ozone/pull/4262#issuecomment-1428352361

   @sumitagrawl can you please take a look as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org