You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/16 21:33:43 UTC
[GitHub] [flink] XComp opened a new pull request #17812: [hotfix][e2e] Adds missing quotes
XComp opened a new pull request #17812:
URL: https://github.com/apache/flink/pull/17812
There's going to be a parsing issue reported if no parameter is passed due to
the if condition being rendered to [ == '1' ]. Adding the quotes fixes this
problem.
This is not really an issue in CI because we always pass a parameter. The `README.md`, though, still states calling this script without a parameter which reveals the issue.
## What is the purpose of the change
Fixing this issue removes the warning that is printed when calling `flink-end-to-end-tests/run-nightly-tests.sh` without a parameter:
```
$ FLINK_DIR=build-target/ ./flink-end-to-end-tests/run-nightly-tests.sh
[...]
==============================================================================
Running bash end-to-end tests
==============================================================================
flink-end-to-end-tests/run-nightly-tests.sh: line 268: [: ==: unary operator expected
flink-end-to-end-tests/run-nightly-tests.sh: line 270: [: ==: unary operator expected
[...]
```
## Brief change log
Adds quotes
## Verifying this change
Testted manually
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17812: [hotfix][e2e] Adds missing quotes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17812:
URL: https://github.com/apache/flink/pull/17812#issuecomment-970701667
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ae63bca783b7c4b537cb31d8279c6b464dadc6c7 (Tue Nov 16 21:38:48 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17812: [hotfix][e2e] Adds missing quotes
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17812:
URL: https://github.com/apache/flink/pull/17812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17812: [hotfix][e2e] Adds missing quotes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17812:
URL: https://github.com/apache/flink/pull/17812#issuecomment-970699581
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ae63bca783b7c4b537cb31d8279c6b464dadc6c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26630",
"triggerID" : "ae63bca783b7c4b537cb31d8279c6b464dadc6c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae63bca783b7c4b537cb31d8279c6b464dadc6c7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26630)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17812: [hotfix][e2e] Adds missing quotes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17812:
URL: https://github.com/apache/flink/pull/17812#issuecomment-970699581
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ae63bca783b7c4b537cb31d8279c6b464dadc6c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae63bca783b7c4b537cb31d8279c6b464dadc6c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae63bca783b7c4b537cb31d8279c6b464dadc6c7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17812: [hotfix][e2e] Adds missing quotes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17812:
URL: https://github.com/apache/flink/pull/17812#issuecomment-970699581
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ae63bca783b7c4b537cb31d8279c6b464dadc6c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26630",
"triggerID" : "ae63bca783b7c4b537cb31d8279c6b464dadc6c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae63bca783b7c4b537cb31d8279c6b464dadc6c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26630)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org