all tests passed but still got ‘Some checks were not successful’

[hong mao <ma...@gmail.com>]

Hi all,
I submitted a PR and all testcases passed in Jenkins, but I still got a
'Some checks were not successful' tip. Could anybody give some advices?
Here's the PR link https://github.com/apache/kafka/pull/7153
[image: image.png]

Thanks!

Re: all tests passed but still got ‘Some checks were not successful’

[Colin McCabe <cm...@apache.org>]

I think we've been having some test runs hit the 4-hour time limit recently.  I saw a few of those as well.

This is just a guess, but I bet that there is a test that is hanging, and has no time limit configured.

We should probably have time limits on every test.  The person writing the test should know what the most appropriate time limit is (30 seconds, 5 minutes, whatever) and should put in a timeout with code like this:

>    @Rule
>    final public Timeout globalTimeout = Timeout.millis(120000);

That will avoid wasting a lot of Jenkins (and developer!) time.

best,
Colin


On Sun, Aug 18, 2019, at 08:19, M. Manna wrote:
> Could you send a retest ? Add “Retest this please” comment. It’ll kick off.
> 
> On Sun, 18 Aug 2019 at 16:16, hong mao <ma...@gmail.com> wrote:
> 
> > Hi all,
> > I submitted a PR and all testcases passed in Jenkins, but I still got a
> > 'Some checks were not successful' tip. Could anybody give some advices?
> > Here's the PR link https://github.com/apache/kafka/pull/7153
> > [image: image.png]
> >
> > Thanks!
> >
>

Re: all tests passed but still got ‘Some checks were not successful’

["M. Manna" <ma...@gmail.com>]

Could you send a retest ? Add “Retest this please” comment. It’ll kick off.

On Sun, 18 Aug 2019 at 16:16, hong mao <ma...@gmail.com> wrote:

> Hi all,
> I submitted a PR and all testcases passed in Jenkins, but I still got a
> 'Some checks were not successful' tip. Could anybody give some advices?
> Here's the PR link https://github.com/apache/kafka/pull/7153
> [image: image.png]
>
> Thanks!
>