You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/03 10:08:36 UTC
[GitHub] [tvm] jtuyls opened a new pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version
jtuyls opened a new pull request #7575:
URL: https://github.com/apache/tvm/pull/7575
This updates the CI PyXIR version and is needed for testing another PR that adds Vitis AI support to TVMC.
@leandron @comaniac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7575:
URL: https://github.com/apache/tvm/pull/7575#issuecomment-789916563
Thanks @jtuyls @leandron
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #7575:
URL: https://github.com/apache/tvm/pull/7575#issuecomment-801270456
@tqchen we need to rebuild the Docker images with this change, so that we can merge #7577 - are there plans to rebuild them anytime soon?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #7575:
URL: https://github.com/apache/tvm/pull/7575#discussion_r586291160
##########
File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh
##########
@@ -23,7 +23,7 @@ set -o pipefail
export PYXIR_HOME=/opt/pyxir
mkdir "$PYXIR_HOME"
-pip3 install progressbar
+pip3 install progressbar h5py==2.10.0
Review comment:
This probably requires your tutorial to be updated as well:
https://github.com/apache/tvm/blob/1455536cc22465cd6b7f6dde4f235c89ed4c5c3c/docs/deploy/vitis_ai.rst#L353
Note: this dependency is also mentioned on the [tensorflow installation script](https://github.com/apache/tvm/blob/0dc7de512b0328d15e85ba5c49234e9993493d2d/docker/install/ubuntu_install_tensorflow.sh) as `"h5py<3.0"`, so despite the duplication I think it is OK (quick mention to @areusch in this initiative to unify python deps).
##########
File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh
##########
@@ -23,7 +23,7 @@ set -o pipefail
export PYXIR_HOME=/opt/pyxir
mkdir "$PYXIR_HOME"
-pip3 install progressbar
+pip3 install progressbar h5py==2.10.0
-git clone --recursive --branch v0.1.3 https://github.com/Xilinx/pyxir.git "${PYXIR_HOME}"
+git clone --recursive --branch v0.1.6 https://github.com/Xilinx/pyxir.git "${PYXIR_HOME}"
Review comment:
Do you think it worth adding a `--depth 1` here so that you only clone the last commit in the branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac merged pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version
Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7575:
URL: https://github.com/apache/tvm/pull/7575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #7575:
URL: https://github.com/apache/tvm/pull/7575#discussion_r586291160
##########
File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh
##########
@@ -23,7 +23,7 @@ set -o pipefail
export PYXIR_HOME=/opt/pyxir
mkdir "$PYXIR_HOME"
-pip3 install progressbar
+pip3 install progressbar h5py==2.10.0
Review comment:
This probably requires your tutorial to be updated as well:
https://github.com/apache/tvm/blob/1455536cc22465cd6b7f6dde4f235c89ed4c5c3c/docs/deploy/vitis_ai.rst#L353
Note: this dependency is also mentioned on the [tensorflow installation script](https://github.com/apache/tvm/blob/0dc7de512b0328d15e85ba5c49234e9993493d2d/docker/install/ubuntu_install_tensorflow.sh) as `"h5py<3.0"`, so despite the duplication I think it is OK (quick mention to @areusch w.r.t. initiative to unify python deps).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jtuyls commented on a change in pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version
Posted by GitBox <gi...@apache.org>.
jtuyls commented on a change in pull request #7575:
URL: https://github.com/apache/tvm/pull/7575#discussion_r586315668
##########
File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh
##########
@@ -23,7 +23,7 @@ set -o pipefail
export PYXIR_HOME=/opt/pyxir
mkdir "$PYXIR_HOME"
-pip3 install progressbar
+pip3 install progressbar h5py==2.10.0
Review comment:
This is the issue with 2.8.0:
`ERROR: tensorflow 2.3.1 has requirement h5py<2.11.0,>=2.10.0, but you'll have h5py 2.8.0 which is incompatible.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jtuyls commented on a change in pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version
Posted by GitBox <gi...@apache.org>.
jtuyls commented on a change in pull request #7575:
URL: https://github.com/apache/tvm/pull/7575#discussion_r586309399
##########
File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh
##########
@@ -23,7 +23,7 @@ set -o pipefail
export PYXIR_HOME=/opt/pyxir
mkdir "$PYXIR_HOME"
-pip3 install progressbar
+pip3 install progressbar h5py==2.10.0
Review comment:
Yeah, it actually works with both 2.8.0 and 2.10.0 but I noticed a dependency issue with 2.8.0 (Tensorflow requires 2.10.0) and fixed it to 2.10.0, which works for us and should work for Tensorflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jtuyls commented on a change in pull request #7575: [CI][VitisAI] Update CI Vitis AI PyXIR version
Posted by GitBox <gi...@apache.org>.
jtuyls commented on a change in pull request #7575:
URL: https://github.com/apache/tvm/pull/7575#discussion_r586319751
##########
File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh
##########
@@ -23,7 +23,7 @@ set -o pipefail
export PYXIR_HOME=/opt/pyxir
mkdir "$PYXIR_HOME"
-pip3 install progressbar
+pip3 install progressbar h5py==2.10.0
-git clone --recursive --branch v0.1.3 https://github.com/Xilinx/pyxir.git "${PYXIR_HOME}"
+git clone --recursive --branch v0.1.6 https://github.com/Xilinx/pyxir.git "${PYXIR_HOME}"
Review comment:
Yes, I added it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org