[jira] [Created] (DRILL-810) Add isSafe() to NullableValueVector. Run-time code should check isSafe() for null value to ensure spare available.

["Jinfeng Ni (JIRA)" <ji...@apache.org>]

Jinfeng Ni created DRILL-810:
--------------------------------

             Summary: Add isSafe() to NullableValueVector.  Run-time code should check isSafe() for null value to ensure spare available.  
                 Key: DRILL-810
                 URL: https://issues.apache.org/jira/browse/DRILL-810
             Project: Apache Drill
          Issue Type: Bug
            Reporter: Jinfeng Ni
            Assignee: Jinfeng Ni


In Drill's run-time generated code, if an expression's output type is of nullable, the run-time will call setSafe() only when the output value is not null. When the output value is null, there is no check at all. However, the value vector may not hold any additional null value, because its offset value vector may run out of space.  The missing checking will cause the run-time code to continue to add null value to the nullable value vector, and could hit IOBE in down stream operator.

In stead, we should add a new method to all nullable value vector, to make sure it still has capacity to hold new value in the run-time code.





--
This message was sent by Atlassian JIRA
(v6.2#6252)