You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <de...@db.apache.org> on 2006/02/11 00:36:56 UTC
[jira] Created: (DERBY-955) Get derbyall on jdk1.6
Get derbyall on jdk1.6
----------------------
Key: DERBY-955
URL: http://issues.apache.org/jira/browse/DERBY-955
Project: Derby
Type: Bug
Components: Test
Versions: 10.2.0.0
Reporter: Rick Hillegas
Fix For: 10.2.0.0
This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Rick Hillegas updated DERBY-955:
--------------------------------
Attachment: bug955_wireUpJDBC4Suite.diff
Committed bug955_wireUpJDBC4Suite.diff at subversion revision 396973. This adds the jdbc4 suite to derbyall. Derbyall ran cleanly for me under jdk1.6 except for the wisconsin noise and some diffs in the multi test suite. I re-ran that suite and it passed. We should keep an eye on the instability in this suite.
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff, bug955_wireUpJDBC4Suite.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Rick Hillegas reassigned DERBY-955:
-----------------------------------
Assign To: Anurag Shekhar
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Rick Hillegas updated DERBY-955:
--------------------------------
Attachment: bug955_sysinfo.diff
After more experiments, it turns out that the sysinfo/sysinfo_withproperties diffs also turn up under jdk1.4 when running against the classtree under cygwin on xp. The problem appears to be that a permission which was granted to the jar files was not granted to the classtree. I am attaching a patch which grants this permission to the classtree: bug955_sysinfo.diff. The patch touches the following file:
M java\testing\org\apache\derbyTesting\functionTests\util\derby_tests.policy
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Rick Hillegas updated DERBY-955:
--------------------------------
Attachment: bug955_blobclob4BLOB.diff
Attaching patch bug955_blobclob4BLOB.diff which replaces an exception-printing with an assertion. This lets us eliminate jdk16-specific canons for the blobclob4BLOB test. The eliminated canons have not been tracking changes to this test. Touches the following files:
M java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\blobclob4BLOB.java
D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\blobclob4BLOB.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\blobclob4BLOB.out
M java\testing\org\apache\derbyTesting\functionTests\master\blobclob4BLOB.out
D java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\blobclob4BLOB.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\blobclob4BLOB.out
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_blobclob4BLOB.diff, bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff, bug955_wireUpJDBC4Suite.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by "Olav Sandstaa (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Olav Sandstaa updated DERBY-955:
--------------------------------
Derby Info: [Patch Available]
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_blobclob4BLOB.diff, bug955_derbyall.diff, bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff, bug955_wireUpJDBC4ClientSuite.diff, bug955_wireUpJDBC4Suite.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=comments#action_12376250 ]
Rick Hillegas commented on DERBY-955:
-------------------------------------
Committed bug955_sysinfo.diff at subversion revision 396875. Derbyall runs cleanly under 1.4 and the sysinfo/sysinfo_withproperties diffs disappear under 1.4 and 1.6.
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=comments#action_12373162 ]
Rick Hillegas commented on DERBY-955:
-------------------------------------
Committed at subversion revision 391384. I merged with the mainline and cleanly reran, under jdk1.6, all the tests whose canons I touched.
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_sed_SQLException.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-955) Get derbyall on jdk1.6
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=comments#action_12417553 ]
Knut Anders Hatlen commented on DERBY-955:
------------------------------------------
I plan to review and commit Olav's patch. If someone has comments or is planning to review, please let me know. Thanks!
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_blobclob4BLOB.diff, bug955_derbyall.diff, bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff, bug955_wireUpJDBC4ClientSuite.diff, bug955_wireUpJDBC4Suite.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Rick Hillegas closed DERBY-955.
-------------------------------
Resolution: Fixed
The original raft of errors have been fixed. We can now log separate JIRAs for individual errors which turn up in the jdk16 test run.
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assigned To: Anurag Shekhar
> Fix For: 10.2.0.0
>
> Attachments: bug955_blobclob4BLOB.diff, bug955_derbyall.diff, bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff, bug955_wireUpJDBC4ClientSuite.diff, bug955_wireUpJDBC4Suite.diff
>
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Knut Anders Hatlen updated DERBY-955:
-------------------------------------
Attachment: bug955_wireUpJDBC4ClientSuite.diff
Committed bug955_wireUpJDBC4ClientSuite.diff with revision 406278. This patch enables jdbc40 in derbynetclientmats. Ran derbyall on JVM 1.5 and 1.6. Verified that derbynetclientmats skipped jdbc40 with JVM 1.5 and ran it successfully with JVM 1.6.
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_blobclob4BLOB.diff, bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff, bug955_wireUpJDBC4ClientSuite.diff, bug955_wireUpJDBC4Suite.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-955) Get derbyall on jdk1.6
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=comments#action_12417592 ]
Knut Anders Hatlen commented on DERBY-955:
------------------------------------------
The patch looks clean and simple. Ran derbyall on jdk15 with one error (runtimeinfo.java which fails more or less all the time on my machine) and on jdk16 with ten errors (DerbyNetAutoStart with the client driver and JCC + four errors in the jdbc40 suite (both client and embedded) caused by new overloads that are not implemented yet). Committed bug955_derbyall.diff into trunk with revision 416889.
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_blobclob4BLOB.diff, bug955_derbyall.diff, bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff, bug955_wireUpJDBC4ClientSuite.diff, bug955_wireUpJDBC4Suite.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Bryan Pendleton <bp...@amberpoint.com>.
Rick Hillegas wrote:
> Here's the security exception I'm seeing when running sysinfo under 1.6
> on windows against the classtree:
>
> access denied (java.io.FilePermission C:\cygwin\home\rh161140\derby\bug955\trunk\classes read)
I don't know if this is a bug in the JDK or not, but at least it should
give you enough information to be able to try a small standalone
java program which calls File.getCanonicalPath against the classes
directory, and then you've got a much simpler example to go to the
JDK support guys with.
Something like the following, when run with -Djava.security.manager and
-Djava.security.policy pointing to an appropriate policy file, should hopefully
do it.
thanks,
bryan
public class t
{
public static void main(String []args) throws Exception
{
System.out.println(new java.io.File(args[0]).getCanonicalPath());
}
}
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Rick Hillegas <Ri...@Sun.COM>.
Hi Bryan,
Thanks for pointing me into derby.log. There I see a security exception
(appended later on in this message). I have run the following
experiments using the sysinfo test:
Legend:
Solaris1.4Jars - On Solaris using jdk1.4 against the Derby Jars
Solaris1.4Classtree - On Solaris using jdk1.4 against the Derby classtree
Solaris1.6Jars - On Solaris using jdk1.6 against the Derby Jars
Solaris1.6Classtree - On Solaris using jdk1.6 against the Derby classtree
Win1.4Jars - On Windows using jdk1.4 against the Derby Jars
Win1.4Classtree - On Windows using jdk1.4 against the Derby classtree
Win1.6Jars - On Windows using jdk1.6 against the Derby Jars
Win1.6Classtree - On Windows using jdk1.6 against the Derby classtree
With the following results:
PASS:
Solaris1.4Jars
Solaris1.4Classtree
Solaris1.6Jars
Solaris1.6Classtree
Win1.4Jars
Win1.4Classtree
Win1.6Jars
FAIL:
Win1.6Classtree
Perhaps this is a bug in the windows 1.6 jdk?
Regards,
-Rick
Here's the security exception I'm seeing when running sysinfo under 1.6
on windows against the classtree:
access denied (java.io.FilePermission
C:\cygwin\home\rh161140\derby\bug955\trunk\classes read)
java.security.AccessControlException: access denied
(java.io.FilePermission
C:\cygwin\home\rh161140\derby\bug955\trunk\classes read)
at
java.security.AccessControlContext.checkPermission(AccessControlContext.java:321)
at
java.security.AccessController.checkPermission(AccessController.java:546)
at java.lang.SecurityManager.checkPermission(SecurityManager.java:532)
at java.lang.SecurityManager.checkRead(SecurityManager.java:871)
at java.io.File.exists(File.java:731)
at java.io.Win32FileSystem.canonicalize(Win32FileSystem.java:402)
at java.io.File.getCanonicalPath(File.java:559)
at org.apache.derby.impl.tools.sysinfo.Main.formatURL(Unknown Source)
at
org.apache.derby.impl.tools.sysinfo.Main.loadZipFromResource(Unknown Source)
at org.apache.derby.impl.tools.sysinfo.Main.getAllInfo(Unknown Source)
at org.apache.derby.impl.tools.sysinfo.Main.reportCloudscape(Unknown
Source)
at org.apache.derby.impl.tools.sysinfo.Main.getMainInfo(Unknown Source)
at
org.apache.derby.impl.drda.NetworkServerControlImpl.getCLSSysInfo(Unknown
Source)
at
org.apache.derby.impl.drda.NetworkServerControlImpl.sendSysInfo(Unknown
Source)
at
org.apache.derby.impl.drda.NetworkServerControlImpl.processCommands(Unknown
Source)
at
org.apache.derby.impl.drda.DRDAConnThread.sessionInitialState(Unknown
Source)
at org.apache.derby.impl.drda.DRDAConnThread.run(Unknown Source)
Bryan Pendleton wrote:
> Rick Hillegas wrote:
>
>> Testing Sysinfo
>> org.apache.derby.drda.NetworkServerControl sysinfo
>> Invalid reply from network server: Insufficient data.
>> End test
>
>
> Ouch!
>
> Assuming this is reproducible, I think there should be something in
> the derby.log for the Network Server process.
>
> When you get some spare time, can you poke around and see if you
> can find that log, and anything interesting in it?
>
> thanks,
>
> bryan
>
>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Bryan Pendleton <bp...@amberpoint.com>.
Rick Hillegas wrote:
> Testing Sysinfo
> org.apache.derby.drda.NetworkServerControl sysinfo
> Invalid reply from network server: Insufficient data.
> End test
Ouch!
Assuming this is reproducible, I think there should be something in
the derby.log for the Network Server process.
When you get some spare time, can you poke around and see if you
can find that log, and anything interesting in it?
thanks,
bryan
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Rick Hillegas <Ri...@Sun.COM>.
Hi Bryan,
I am seeing the following error at the beginning of the sysinfo test,
when I run it under jdk16:
Testing Sysinfo
org.apache.derby.drda.NetworkServerControl sysinfo
Invalid reply from network server: Insufficient data.
End test
The test then continues. The error is DRDA_InvalidReplyTooShort raised
by NetworkServerControlImpl. That class raises that error in several
places and I haven't tracked down where it's happening. From the
sysinfo.java code, it appears that the test is trying to execute the
following command:
org.apache.derby.drda.NetworkServerControl sysinfo
When I bring up a 1.6 network server and issue this command outside the
test, I don't see the error.
Regards,
-Rick
Bryan Pendleton wrote:
> Rick Hillegas (JIRA) wrote:
>
>> With this submission, we are down to the wisconsin noise plus some
>> diffs in sysinfo and sysinfo_withProperties.
>
>
> Can you summarize the sysinfo issue, Rick?
>
> I don't have access to JDK 1.6 right now, but would be glad to help.
>
> thanks,
>
> bryan
>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Bryan Pendleton <bp...@amberpoint.com>.
Rick Hillegas (JIRA) wrote:
> With this submission, we are down to the wisconsin noise plus some diffs in sysinfo and sysinfo_withProperties.
Can you summarize the sysinfo issue, Rick?
I don't have access to JDK 1.6 right now, but would be glad to help.
thanks,
bryan
[jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Rick Hillegas updated DERBY-955:
--------------------------------
Attachment: bug955_sed2.diff
Eliminate another set of derbyall diffs under jdk1.6. Committed patch bug955_sed2.diff at revision 394952. Touches these files:
M java\testing\org\apache\derbyTesting\functionTests\harness\Sed.java
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\dblook_test.out
With this submission, we are down to the wisconsin noise plus some diffs in sysinfo and sysinfo_withProperties.
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_sed2.diff, bug955_sed_SQLException.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Mayuresh Nirhali <Ma...@Sun.COM>.
Hello,
attached svn status output to JIRA Derby-1072.
Thanks
Mayuresh
Rick Hillegas wrote:
> Hi Mayuresh,
>
> Thanks for the warning. Looks like Satheesh is reviewing your patch
> already. Could you do me a favor and attach the output of "svn status"
> to the JIRA so that I can see at a glance what files were changed?
>
> Thanks,
> -Rick
>
> Mayuresh Nirhali wrote:
>
>> Rick,
>>
>> I submitted a patch last week for DERBY-1072 which involved
>> modifications to lot of canon files.
>> I am hoping that someone would review that patch and commit if it is
>> okay ?
>> I thought I should let you know as lot of files I see in your list
>> are modified.
>>
>> Thanks
>> Mayuresh
>>
>> Rick Hillegas wrote:
>>
>>> Hi Bryan,
>>>
>>> Yes, please drop in your changes first. It turns out I'm going to
>>> have to regenerate this patch because a boatload of canon changes
>>> went in over the weekend. Are you planning to commit your changes
>>> today? It would be great if I could merge and regenerate
>>> mid-afternoon San Francisco time.
>>>
>>> Thanks,
>>> -Rick
>>>
>>>
>>> Bryan Pendleton wrote:
>>>
>>>>> In addition, this patch gets rid of many of the jdk16-specific
>>>>> canons.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Yay!
>>>>
>>>> The only downside is, both you and I want to touch
>>>> master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
>>>> don't have an easy way to re-make my changes after yours, because I
>>>> don't have access to a JDK 1.6 environment yet.
>>>>
>>>> So can I submit my DERBY-349 change first?
>>>>
>>>> thanks,
>>>>
>>>> bryan
>>>>
>>>>
>>>
>>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Rick Hillegas <Ri...@Sun.COM>.
Hi Mayuresh,
Thanks for the warning. Looks like Satheesh is reviewing your patch
already. Could you do me a favor and attach the output of "svn status"
to the JIRA so that I can see at a glance what files were changed?
Thanks,
-Rick
Mayuresh Nirhali wrote:
> Rick,
>
> I submitted a patch last week for DERBY-1072 which involved
> modifications to lot of canon files.
> I am hoping that someone would review that patch and commit if it is
> okay ?
> I thought I should let you know as lot of files I see in your list are
> modified.
>
> Thanks
> Mayuresh
>
> Rick Hillegas wrote:
>
>> Hi Bryan,
>>
>> Yes, please drop in your changes first. It turns out I'm going to
>> have to regenerate this patch because a boatload of canon changes
>> went in over the weekend. Are you planning to commit your changes
>> today? It would be great if I could merge and regenerate
>> mid-afternoon San Francisco time.
>>
>> Thanks,
>> -Rick
>>
>>
>> Bryan Pendleton wrote:
>>
>>>> In addition, this patch gets rid of many of the jdk16-specific canons.
>>>
>>>
>>>
>>>
>>> Yay!
>>>
>>> The only downside is, both you and I want to touch
>>> master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
>>> don't have an easy way to re-make my changes after yours, because I
>>> don't have access to a JDK 1.6 environment yet.
>>>
>>> So can I submit my DERBY-349 change first?
>>>
>>> thanks,
>>>
>>> bryan
>>>
>>>
>>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Mayuresh Nirhali <Ma...@Sun.COM>.
Rick,
I submitted a patch last week for DERBY-1072 which involved
modifications to lot of canon files.
I am hoping that someone would review that patch and commit if it is okay ?
I thought I should let you know as lot of files I see in your list are
modified.
Thanks
Mayuresh
Rick Hillegas wrote:
> Hi Bryan,
>
> Yes, please drop in your changes first. It turns out I'm going to have
> to regenerate this patch because a boatload of canon changes went in
> over the weekend. Are you planning to commit your changes today? It
> would be great if I could merge and regenerate mid-afternoon San
> Francisco time.
>
> Thanks,
> -Rick
>
>
> Bryan Pendleton wrote:
>
>>> In addition, this patch gets rid of many of the jdk16-specific canons.
>>
>>
>>
>> Yay!
>>
>> The only downside is, both you and I want to touch
>> master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
>> don't have an easy way to re-make my changes after yours, because I
>> don't have access to a JDK 1.6 environment yet.
>>
>> So can I submit my DERBY-349 change first?
>>
>> thanks,
>>
>> bryan
>>
>>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Bryan Pendleton <bp...@amberpoint.com>.
Rick Hillegas wrote:
> Yes, please drop in your changes first.
Thanks, Rick. I committed the test changes to subversion as:
http://svn.apache.org/viewcvs?rev=391086&view=rev
thanks,
bryan
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Rick Hillegas <Ri...@Sun.COM>.
Hi Bryan,
Yes, please drop in your changes first. It turns out I'm going to have
to regenerate this patch because a boatload of canon changes went in
over the weekend. Are you planning to commit your changes today? It
would be great if I could merge and regenerate mid-afternoon San
Francisco time.
Thanks,
-Rick
Bryan Pendleton wrote:
>> In addition, this patch gets rid of many of the jdk16-specific canons.
>
>
> Yay!
>
> The only downside is, both you and I want to touch
> master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
> don't have an easy way to re-make my changes after yours, because I
> don't have access to a JDK 1.6 environment yet.
>
> So can I submit my DERBY-349 change first?
>
> thanks,
>
> bryan
>
>
Re: [jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by Bryan Pendleton <bp...@amberpoint.com>.
> In addition, this patch gets rid of many of the jdk16-specific canons.
Yay!
The only downside is, both you and I want to touch
master/DerbyNetClient/jdk16/parameterMapping.out, and I unfortunately
don't have an easy way to re-make my changes after yours, because I
don't have access to a JDK 1.6 environment yet.
So can I submit my DERBY-349 change first?
thanks,
bryan
[jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Rick Hillegas updated DERBY-955:
--------------------------------
Attachment: bug955_sed_SQLException.diff
This patch eliminates the diffs in a couple more derbyall tests under 1.6:
grantRevokeDDL
SURTest
savepointJdbc30*
iepnegativetests_ES
statementJdbc30
In addition, this patch gets rid of many of the jdk16-specific canons. What this patch does is add some masking logic to Sed.java to handle the fact that SQLException was split into subclasses in JDBC4. Derbyall runs cleanly (modulo expected diffs) under 1.4. The jdbc4 tests also run cleanly. The contents of this patch are:
M java\engine\org\apache\derby\impl\jdbc\Util.java
M java\testing\org\apache\derbyTesting\functionTests\tests\derbynet\testij.java
M java\testing\org\apache\derbyTesting\functionTests\harness\RunTest.java
M java\testing\org\apache\derbyTesting\functionTests\harness\Sed.java
M java\testing\org\apache\derbyTesting\functionTests\harness\JavaVersionHolder.java
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\importExport.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\metadata.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\procedure.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\ieptests.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNet\jdk16\odbc_metadata.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\SURTest.out
M java\testing\org\apache\derbyTesting\functionTests\master\jdk16\closed.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\outparams.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\iepnegativetests.out
M java\testing\org\apache\derbyTesting\functionTests\master\jdk16\releaseCompileLocks.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\checkDataSource.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\procedure.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\statementJdbc20.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\statementJdbc30.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\Stream.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\checkDataSource30.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\nestedCommit.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\parameterMapping.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\TransactionTable.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\ieptests.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\importExportThruIJ.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\compressTable.out
D java\testing\org\apache\derbyTesting\functionTests\master\jdk16\streamingColumn.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\importExport.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\metadata.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\procedure.out
A java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\Stream.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\ieptests.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\odbc_metadata.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\savepointJdbc30_JSR169.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\savepointJdbc30_XA.out
M java\testing\org\apache\derbyTesting\functionTests\master\DerbyNetClient\jdk16\parameterMapping.out
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_sed_SQLException.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-955) Get derbyall on jdk1.6
Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=comments#action_12377573 ]
Rick Hillegas commented on DERBY-955:
-------------------------------------
Committed bug955_blobclob4BLOB.diff at subversion revision 399293. Derbyall runs cleanly on jdk1.4 modulo the wisconsin diffs.
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_blobclob4BLOB.diff, bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff, bug955_wireUpJDBC4Suite.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-955) Get derbyall on jdk1.6
Posted by "Olav Sandstaa (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-955?page=all ]
Olav Sandstaa updated DERBY-955:
--------------------------------
Attachment: bug955_derbyall.diff
This patch contains fixes to the following tests that are failing when
running derbyall with jdk 1.6:
* derbynetclientmats: tools/ieptests.sql
-updated master file for jdk16
* derbynetclientmats: jdbcapi/parameterMappint.java
-REMOVED jdk16 specific master file
* derbynetclientmats: jdbcapi/checkDataSource30.java
-updated checkDataSource30.java and checkDataSource.java to produce
output that is the same when running with jdk15 and jdk16
-updated master files to reflect changes in output
* derbynetmats: tools/ieptests.sql
-updated master file for jdk16
svn status reports:
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/checkDataSource30.java
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/checkDataSource.java
M java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/jdk16/ieptests.out
M java/testing/org/apache/derbyTesting/functionTests/master/checkDataSource30.out
D java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/jdk16/parameterMapping.out
M java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/jdk16/ieptests.out
M java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/checkDataSource.out
M java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/checkDataSource30.out
M java/testing/org/apache/derbyTesting/functionTests/master/checkDataSource.out
Note: one master file has been removed.
I have run derbyall with jdk 1.5 and 1.6.
The patch is ready for review and commit.
> Get derbyall on jdk1.6
> ----------------------
>
> Key: DERBY-955
> URL: http://issues.apache.org/jira/browse/DERBY-955
> Project: Derby
> Type: Bug
> Components: Test
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Anurag Shekhar
> Fix For: 10.2.0.0
> Attachments: bug955_blobclob4BLOB.diff, bug955_derbyall.diff, bug955_sed2.diff, bug955_sed_SQLException.diff, bug955_sysinfo.diff, bug955_wireUpJDBC4ClientSuite.diff, bug955_wireUpJDBC4Suite.diff
>
> This bug is a placeholder for patches which enable derbyall to run on jdk1.6.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira