[jira] [Commented] (MNG-4777) Match property for profile activation against a regex

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229683#comment-15229683 ] 

ASF GitHub Bot commented on MNG-4777:
-------------------------------------

GitHub user vjkoskela opened a pull request:

    https://github.com/apache/maven/pull/80

    [MNG-4777] Match property for profile activation against a regex

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vjkoskela/maven mng-4777

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #80
    
----
commit 2f81de5d883c76ff60e60666d1ffafac6a4f3dcb
Author: Ville Koskela <vk...@groupon.com>
Date:   2016-04-07T04:43:53Z

    [MNG-4777] Match property for profile activation against a regex

----


> Match property for profile activation against a regex
> -----------------------------------------------------
>
>                 Key: MNG-4777
>                 URL: https://issues.apache.org/jira/browse/MNG-4777
>             Project: Maven
>          Issue Type: Improvement
>          Components: Profiles
>    Affects Versions: 2.0.11
>            Reporter: Andreas Ebbert-Karroum
>         Attachments: regex-project-property-profile-activator.patch
>
>
> For activating a profile it would be nice, in addition or as a seperate feature to MNG-3328, to match a property not against a specific value but against a regex. In our case, we need to set some properties for some hudson builds. Not only is that setup fragile against job name changes, but also doesn't scale for multiple jobs. IMHO adding a regex matcher would be a nice feature for multiple purposes.
> Old:
> {code:xml}
> <activation>
>   <property>
>     <name>env.JOB_NAME</name>
>     <value>xyz-abc-foo/label=robotframework,maven.browser-profile=firefox,maven.env-profile=dev</value>
>   </property>
> </activation>
> {code}
> New:
> {code:xml}
> <activation>
>   <property>
>     <name>env.JOB_NAME</name>
>     <regex>xyz-abc-foo/.*</regex>
>   </property>
> </activation>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)