You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/08/19 09:53:54 UTC
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/716
Changed AddressFormat elements to reflect changes in IPv4 and IPv6 refactor.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/716.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #716
----
commit 070083af0dd1d95e7c5e30fd41f46c3e6541e2cc
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-08-17T20:51:57Z
Changed AddressFormat elements to reflect changes in IPv4 and IPv6 refactor.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-133758939
Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-132646596
@remibergsma You are correct. Those are all not related to the AddressFormat enum. Of course all should be renamed, but doing so in 1 time will also will not benefit the process of making the code more readable.
I'll will stack up some commits before making a new pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-132497888
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/716
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-132643862
@borisroman If I run this `grep -r Ip4 *` I see many references to `Ip4`. Isn't this going to be confusing to rename a part of it only? Or am I missing something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Changed AddressFormat elements to reflect...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-133543333
@borisroman I suggest you close this PR and do all the refactor work in a separate branch, as discussed. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---