You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by syucream <gi...@git.apache.org> on 2014/05/10 10:51:23 UTC
[GitHub] trafficserver pull request: Fix the automake rule to satisfy heade...
GitHub user syucream opened a pull request:
https://github.com/apache/trafficserver/pull/80
Fix the automake rule to satisfy header requirements of atscppapi
When I built my plugin outside of trafficserver source tree, I found build failure related to header requirements of atscppapi as below logs.
```
# I set /usr/local/trafficserver/ as prefix.
In file included from /usr/local/trafficserver/include/atscppapi/Transaction.h:30:
/usr/local/trafficserver/include/atscppapi/shared_ptr.h:28:10: fatal error: 'ink_autoconf.h' file not found
#include "ink_autoconf.h"
^
1 error generated.
```
The shared_ptr.h requires a variable defined on ink_autoconf.h but it doesn't exist in destination directory. so I'll fix by installing it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/syucream/trafficserver fix/atscppapi
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit c4446cbacfc98208cbabf67e9388c8e9500fd368
Author: syucream <sy...@gmail.com>
Date: 2014-05-10T08:32:27Z
Fix the automake rule to satisfy header requirements of atscppapi
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Fix the automake rule to satisfy heade...
Posted by syucream <gi...@git.apache.org>.
Github user syucream closed the pull request at:
https://github.com/apache/trafficserver/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Fix the automake rule to satisfy heade...
Posted by syucream <gi...@git.apache.org>.
Github user syucream commented on the pull request:
https://github.com/apache/trafficserver/pull/80#issuecomment-43770175
Thank you for your review. I agree with your opinion and want to continue discussion to solve it on JIRA. so I close this pull-request for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---