You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/08/13 06:40:40 UTC
Review Request 13523: 7 New tests for affinity groups
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
New tests for affinity groups
Diffs
-----
test/integration/component/test_affinity_groups.py 39baf3e
Diff: https://reviews.apache.org/r/13523/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request 13523: 7 New tests for affinity groups
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Aug. 14, 2013, 2:38 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1665
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line1665>
> >
> > The multihost tag is only when the test requires the presence of multiple hosts in it. Please remove it from this and other tests.
Dropped multihost tag from tests where not needed
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/#review25145
-----------------------------------------------------------
On Aug. 15, 2013, 4:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13523/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 4:41 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> New tests for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 39baf3e
>
> Diff: https://reviews.apache.org/r/13523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 13523: 7 New tests for affinity groups
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/#review25145
-----------------------------------------------------------
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/13523/#comment49369>
The multihost tag is only when the test requires the presence of multiple hosts in it. Please remove it from this and other tests.
- Prasanna Santhanam
On Aug. 13, 2013, 4:40 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13523/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 4:40 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> New tests for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 39baf3e
>
> Diff: https://reviews.apache.org/r/13523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 13523: 7 New tests for affinity groups
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Aug. 15, 2013, 5:10 a.m., Prasanna Santhanam wrote:
> > Applied with changes to git summary. Please take care to write a meaningful summary in the next patch.
Wilco. Thanks Prasanna!
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/#review25210
-----------------------------------------------------------
On Aug. 15, 2013, 4:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13523/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 4:41 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> New tests for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 39baf3e
>
> Diff: https://reviews.apache.org/r/13523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 13523: 7 New tests for affinity groups
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/#review25210
-----------------------------------------------------------
Ship it!
Applied with changes to git summary. Please take care to write a meaningful summary in the next patch.
- Prasanna Santhanam
On Aug. 15, 2013, 4:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13523/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 4:41 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> New tests for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 39baf3e
>
> Diff: https://reviews.apache.org/r/13523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 13523: 7 New tests for affinity groups
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/
-----------------------------------------------------------
(Updated Aug. 15, 2013, 4:41 a.m.)
Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
Changes
-------
Updated Diff with changes in line with review comments
Repository: cloudstack-git
Description
-------
New tests for affinity groups
Diffs (updated)
-----
test/integration/component/test_affinity_groups.py 39baf3e
Diff: https://reviews.apache.org/r/13523/diff/
Testing
-------
Thanks,
Ashutosh Kelkar
Re: Review Request 13523: 7 New tests for affinity groups
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 507
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line507>
> >
> > I didn't quite understand this assert. What hostid are we talking about?
The host id is from the VM we created and associated with the group. The test ensures the listing of the group also lists the host id of the vms associated with that affinity group. Updated the assert to better reflect the check being carried out.
> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1594
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line1594>
> >
> > Can we be explicit?
> > "Missing affinity group %s .."
Updated assert to make the check more clear
> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1636
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line1636>
> >
> > remove multihost tag
Dropped multihost tag from test
> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1659
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line1659>
> >
> > "%s affinity groups listed by admin with id %s. Expected 1" % (count, id)
> >
> > ^ This is much better for debugging and takes the form of expected against observed.
Updated assert to be inline with review comment
> On Aug. 14, 2013, 2:46 p.m., Prasanna Santhanam wrote:
> > test/integration/component/test_affinity_groups.py, line 1688
> > <https://reviews.apache.org/r/13523/diff/1/?file=340307#file340307line1688>
> >
> > Improve the assertion to show expected vs observed.
Updated assert to be inline with review comment.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/#review25146
-----------------------------------------------------------
On Aug. 15, 2013, 4:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13523/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 4:41 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> New tests for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 39baf3e
>
> Diff: https://reviews.apache.org/r/13523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 13523: 7 New tests for affinity groups
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/#review25146
-----------------------------------------------------------
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/13523/#comment49370>
I didn't quite understand this assert. What hostid are we talking about?
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/13523/#comment49371>
Can we be explicit?
"Missing affinity group %s .."
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/13523/#comment49373>
remove multihost tag
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/13523/#comment49377>
"%s affinity groups listed by admin with id %s. Expected 1" % (count, id)
^ This is much better for debugging and takes the form of expected against observed.
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/13523/#comment49378>
Improve the assertion to show expected vs observed.
- Prasanna Santhanam
On Aug. 13, 2013, 4:40 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13523/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 4:40 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> New tests for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 39baf3e
>
> Diff: https://reviews.apache.org/r/13523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 13523: 7 New tests for affinity groups
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13523/#review25057
-----------------------------------------------------------
Review 13523 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #116 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/116/
- Jenkins Cloudstack.org
On Aug. 13, 2013, 4:40 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13523/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 4:40 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> New tests for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 39baf3e
>
> Diff: https://reviews.apache.org/r/13523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>