You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2015/11/09 19:27:26 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...
GitHub user r-kamath opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/415
ZEPPELIN-52 Long statements in paragraph and going beneath the control bar
before
<img alt="screen shot 2015-11-09 at 11 55 38 pm" src="https://issues.apache.org/jira/secure/attachment/12726406/Screen%20Shot%202015-04-18%20at%2016.34.46.png">
after
<img width="1109" alt="screen shot 2015-11-09 at 11 55 38 pm" src="https://cloud.githubusercontent.com/assets/2031306/11042490/7008676a-873d-11e5-97f1-7df4c091eeb9.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/incubator-zeppelin ZEPPELIN-52
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/415.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #415
----
commit 98af0fb067173c1ff1ec7da6b1a2847bf9abc3f5
Author: Renjith Kamath <re...@gmail.com>
Date: 2015-11-09T18:24:30Z
ZEPPELIN-52 Long statements in paragraph and going beneath the control bar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...
Posted by r-kamath <gi...@git.apache.org>.
GitHub user r-kamath reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/415
ZEPPELIN-52 Long statements in paragraph and going beneath the control bar
before
<img alt="screen shot 2015-11-09 at 11 55 38 pm" src="https://issues.apache.org/jira/secure/attachment/12726406/Screen%20Shot%202015-04-18%20at%2016.34.46.png">
after
<img width="1109" alt="screen shot 2015-11-09 at 11 55 38 pm" src="https://cloud.githubusercontent.com/assets/2031306/11042490/7008676a-873d-11e5-97f1-7df4c091eeb9.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/incubator-zeppelin ZEPPELIN-52
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/415.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #415
----
commit 98af0fb067173c1ff1ec7da6b1a2847bf9abc3f5
Author: Renjith Kamath <re...@gmail.com>
Date: 2015-11-09T18:24:30Z
ZEPPELIN-52 Long statements in paragraph and going beneath the control bar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-156288959
I think leaving it unchanged is okay for now.
In the future, maybe we can think automatically adds default interpreter name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155399747
Thanks for the improvement.
There was design principles when Zeppelin UI implemented in the beginning.
I just documented that https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61328042
My preference is improvement without adding more empty spaces inside of Paragraph.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155457111
@Leemoonsoo how about we hide the control bar and show it on mouseover event of the paragraph
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155385350
tested, and this works for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155594838
Here's little bit of history.
Currently, Zeppelin has 3 Looknfeels. 'default', 'simple' and 'report'. But before the looknfeel feature, there were only single style, and that was 'simple'. 'default' was introduced as a alternative to 'simple', based on feedbacks
* Hard to distinguish Paragraphs -> gray background
* Hard to find buttons -> controls always shown
Therefore 'default' was intended to show controls always, while 'simple' show only on hover mouse.
It could be challenging, but what do you think make it aware contents length of 1st line and hide (or make it almost transparent) control only when there're text underneath, and show as a normal on mouse hover? Do you think it's a good idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-156287553
I like the newline idea, but %[name] might not be there if it's the default interpreter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155420038
@Leemoonsoo Thanks for the document.
>...without adding more empty spaces inside of Paragraph...
makes sense. working on a better solution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/415
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155709965
Not a big fan of adding too many switch options, there is already many.
One possible way, would be to show those controls outside of the text editor when there is a title shown.
That way, in some case it wouldn't obstruct the editor.
I tried before to play with the opacity of that action buttons component background, but this is pretty much as far as we can go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/415
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155319474
Gave it a spin dosen't work on Firefox and IE 10, but works on chrome, safari and edge (windows 10).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-156279960
Another idea is, when cursor hit the controls, like
Automatically adds newlines char after '%[name]',
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-52 Long statements in pa...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155382830
@prabhjyotsingh tested on Firefox and IE :tada:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [WIP] ZEPPELIN-52 Long statements...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/415#issuecomment-155704705
>what do you think make it aware contents length of 1st line and hide (or make it almost transparent) control only when there're text underneath, and show as a normal on mouse hover?
Will make the paragraph ui inconsistent. how about an auto show/hide option which can be turned on or off. we can call it "Auto hide controls"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---