You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/22 00:09:04 UTC

[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #3211: [GOBBLIN-1370] Switch flow resume to be a restli action

jack-moseley commented on a change in pull request #3211:
URL: https://github.com/apache/incubator-gobblin/pull/3211#discussion_r562279218



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowExecutionResourceHandler.java
##########
@@ -71,15 +71,14 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId, EmptyRecord> key) {
   }
 
   @Override
-  public UpdateResponse resume(ComplexResourceKey<FlowStatusId, EmptyRecord> key) {
+  public void resume(ComplexResourceKey<FlowStatusId, EmptyRecord> key) {

Review comment:
       Not really a reason in particular, restli just gives us the ID as a `ComplexResourceKey` and at some point we have to call getKey to get the `FlowStatusId ` from it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org