You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "AkshayUpadhyay2411 (via GitHub)" <gi...@apache.org> on 2026/10/10 09:54:52 UTC
[PR] Respect explicit append.uuid.to.segment.name in SegmentGenerationAndPushTask [pinot]
AkshayUpadhyay2411 opened a new pull request, #19820:
URL: https://github.com/apache/pinot/pull/19820
Fixes #19819
## Summary
`SegmentGenerationAndPushTask` ignores an explicitly configured `append.uuid.to.segment.name`, so deterministic
segment names (`inputFile`, `simple`, `normalizedDate`) cannot be used with this task.
Two places overrode the configured value (both introduced in #10335):
- **Generator:** unconditionally put top-level `append.uuid.to.segment.name=true` into every task. It now defaults to
`true` only when the batch config has not set it, either top-level or as
`segmentNameGenerator.configs.append.uuid.to.segment.name` (the prefixed value is carried into the top-level key).
- **Executor:** unconditionally overwrote the prefixed generator config with the top-level value (default `false`).
It now only falls back to the top-level key when the prefixed config is absent.
## Compatibility
No config keys are added, removed or renamed, and the default stays `true` for generated tasks. The only change is
that an explicit value is now respected:
- unset: unchanged (`true`)
- `segmentNameGenerator.configs.append.uuid.to.segment.name`: now honored; wins over the top-level key
- top-level `append.uuid.to.segment.name`: now honored when the prefixed key is absent
- tasks submitted without either key: unchanged (`false`)
Tables that already set `false` (which previously had no effect) will start producing deterministic segment names. With
`false`, make sure the name generator yields unique names per input, otherwise segments are overwritten. `FIXED` ignores
the setting.
## Testing
- `SegmentGenerationAndPushTaskGeneratorTest` (new): default, explicit top-level `false`, explicit prefixed `false`,
and a generator -> executor round trip.
- `SegmentGenerationAndPushTaskExecutorTest`: precedence and fallback.
- Verified the new tests fail without the fix.
- `./mvnw spotless:apply license:format checkstyle:check license:check -pl pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks`
## Related
#16909 (open) changes the same generator line to read a top-level batch key with a default of `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Respect explicit append.uuid.to.segment.name in SegmentGenerationAndPushTask [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #19820:
URL: https://github.com/apache/pinot/pull/19820#issuecomment-6134054221
Documentation follow-up merged: https://github.com/pinot-contrib/pinot-docs/pull/1100. Corrects explicit UUID option precedence and warns about cross-run segment-name collisions when UUIDs are disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Respect explicit append.uuid.to.segment.name in SegmentGenerationAndPushTask [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #19820:
URL: https://github.com/apache/pinot/pull/19820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Respect explicit append.uuid.to.segment.name in SegmentGenerationAndPushTask [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19820:
URL: https://github.com/apache/pinot/pull/19820#issuecomment-6131802542
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19820?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 58.31%. Comparing base ([`910f9d5`](https://app.codecov.io/gh/apache/pinot/commit/910f9d5e4942010621c7d791557e0b4c4ffddcfd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4b1746a`](https://app.codecov.io/gh/apache/pinot/commit/4b1746a97015cf67232a2aa434957f2fec1c5942?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (910f9d5) and HEAD (4b1746a). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (910f9d5) | HEAD (4b1746a) |
>|------|------|------|
>|unittests|2|1|
>|java-25|6|1|
>|temurin|6|1|
>|lane-a|2|0|
>|integration|4|0|
>|integration1|2|0|
>|lane-b|2|0|
>|integration2|2|0|
>|unittests2|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19820 +/- ##
=============================================
- Coverage 68.63% 58.31% -10.32%
+ Complexity 1486 1 -1485
=============================================
Files 3526 2713 -813
Lines 230143 168494 -61649
Branches 36562 27558 -9004
=============================================
- Hits 157963 98263 -59700
- Misses 59837 62001 +2164
+ Partials 12343 8230 -4113
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.31% <ø> (-10.32%)` | :arrow_down: |
| [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.31% <ø> (-10.32%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.31% <ø> (-10.32%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.31% <ø> (-0.02%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19820?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org