[GitHub] [flink] rkhachatryan commented on a change in pull request #10847: [FLINK-15578][connectors/jdbc] implement exactly once JDBC sink

[GitBox <gi...@apache.org>]

rkhachatryan commented on a change in pull request #10847:
URL: https://github.com/apache/flink/pull/10847#discussion_r553950894



##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/CheckpointAndXidSerializer.java
##########
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.jdbc.xa;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.typeutils.SimpleTypeSerializerSnapshot;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot;
+import org.apache.flink.core.memory.DataInputView;
+import org.apache.flink.core.memory.DataOutputView;
+
+import javax.transaction.xa.Xid;
+
+import java.io.IOException;
+import java.util.Objects;
+
+/** {@link CheckpointAndXid} serializer. */
+@Internal
+final class CheckpointAndXidSerializer extends TypeSerializer<CheckpointAndXid> {
+
+    private static final TypeSerializerSnapshot<CheckpointAndXid> SNAPSHOT =
+            new SimpleTypeSerializerSnapshot<CheckpointAndXid>(CheckpointAndXidSerializer::new) {
+                private static final int VERSION = 1;
+
+                @Override
+                public void writeSnapshot(DataOutputView out) throws IOException {
+                    super.writeSnapshot(out);
+                    out.writeInt(VERSION);
+                }
+
+                @Override
+                public void readSnapshot(int readVersion, DataInputView in, ClassLoader classLoader)
+                        throws IOException {
+                    super.readSnapshot(readVersion, in, classLoader);
+                    in.readInt();
+                }
+            };
+
+    private final TypeSerializer<Xid> xidSerializer = new XidSerializer();
+
+    @Override
+    public boolean isImmutableType() {
+        return xidSerializer.isImmutableType();
+    }
+
+    @Override
+    public TypeSerializer<CheckpointAndXid> duplicate() {
+        return this;
+    }
+
+    @Override
+    public CheckpointAndXid createInstance() {
+        return CheckpointAndXid.createRestored(0L, 0, xidSerializer.createInstance());
+    }
+
+    @Override
+    public CheckpointAndXid copy(CheckpointAndXid from) {
+        return CheckpointAndXid.createRestored(
+                from.checkpointId, from.attempts, xidSerializer.copy(from.xid));

Review comment:
       Existing `restored` value is not used because `createRestored()` always uses `true`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org