You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/24 13:55:55 UTC
[GitHub] [doris] eldenmoon opened a new pull request, #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
eldenmoon opened a new pull request, #14564:
URL: https://github.com/apache/doris/pull/14564
…tequal` which in `FunctionArrayIndex` handle target NULL
in the previous, the result is:
```
mysql> select array_position([1, null], null);
+--------------------------------------+
| array_position(ARRAY(1, NULL), NULL) |
+--------------------------------------+
| NULL |
+--------------------------------------+
1 row in set (0.02 sec)
```
but after this commit, the result become:
```
mysql> select array_position([1, null], null);
+--------------------------------------+
| array_position(ARRAY(1, NULL), NULL) |
+--------------------------------------+
| 2 |
+--------------------------------------+
1 row in set (0.02 sec)
```
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on PR #14564:
URL: https://github.com/apache/doris/pull/14564#issuecomment-1326492351
The behavior follows ClickHouse as well Starrocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #14564:
URL: https://github.com/apache/doris/pull/14564#issuecomment-1326954606
>
actually array functions follows hive/spark as design, in spark:
`pyspark.sql.functions.array_position: Returns null if either of the arguments are null.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14564:
URL: https://github.com/apache/doris/pull/14564#issuecomment-1326611341
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.48 seconds
load time: 448 seconds
storage size: 17172871749 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221124154443_clickbench_pr_52539.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14564:
URL: https://github.com/apache/doris/pull/14564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju closed pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
Posted by GitBox <gi...@apache.org>.
cambyzju closed pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
URL: https://github.com/apache/doris/pull/14564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14564:
URL: https://github.com/apache/doris/pull/14564#issuecomment-1326962982
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
Posted by GitBox <gi...@apache.org>.
HappenLee commented on PR #14564:
URL: https://github.com/apache/doris/pull/14564#issuecomment-1327218183
> @cambyzju I could provide anthother function to follow the behavior of ClickHouse? I think user may need the behavior
I think the way is better. the spark and hive do the right way. `null do not equal null` in SQL. the clickhouse logic is werid and not right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on PR #14564:
URL: https://github.com/apache/doris/pull/14564#issuecomment-1326958518
@cambyzju I could provide anthother function to follow the behavior of ClickHouse? I think user may need the behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14564: [enhancement](array-function) `array_position`,`array_contains`,`coun…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14564:
URL: https://github.com/apache/doris/pull/14564#issuecomment-1326962964
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org