You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/05/23 23:18:42 UTC
[Bug 53283] New: Add Support for Externalized Data Source
Credentials
https://issues.apache.org/bugzilla/show_bug.cgi?id=53283
Priority: P2
Bug ID: 53283
Assignee: dev@tomcat.apache.org
Summary: Add Support for Externalized Data Source Credentials
Severity: enhancement
Classification: Unclassified
OS: Linux
Reporter: marvin.addison@gmail.com
Hardware: PC
Status: NEW
Version: unspecified
Component: jdbc-pool
Product: Tomcat Modules
For deployment environments where the pooled data source configuration is
either complex, controlled, or both, it would be helpful to allow
externalization of the data source credentials. For example, it would be
straightforward to reference a properties file containing credentials. This
would allow the context definition containing the pooled data source
configuration to be invariant with respect to environment, which would simplify
migration of the data source between hosts or tiers.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53283] Add Support for Externalized Data Source Credentials
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53283
--- Comment #7 from Filip Hanik <fh...@apache.org> ---
No need for the patch, if you implement an object that has the interface:
org.apache.tomcat.util.IntrospectionUtils.PropertySource
and set the PROPERTY_SOURCE system variable as described in
http://tomcat.apache.org/tomcat-7.0-doc/config/systemprops.html
then your object can read the property file itself.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53283] Add Support for Externalized Data Source Credentials
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53283
--- Comment #2 from Marvin Addison <ma...@gmail.com> ---
Created attachment 28828
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28828&action=edit
Patch for externalized credentials in properties file.
Attached patch for this feature made against jdbc-pool-1.2-SNAPSHOT. I've
tested this against tomcat-7.0.27 and works as expected.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53283] Add Support for Externalized Data Source Credentials
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53283
--- Comment #5 from Mark Thomas <ma...@apache.org> ---
http://tomcat.apache.org/tomcat-7.0-doc/config/index.html
Second paragraph. Lots of ways to set the property values for replacement.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53283] Add Support for Externalized Data Source Credentials
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53283
--- Comment #4 from Konstantin Kolinko <kn...@gmail.com> ---
http://wiki.apache.org/tomcat/FAQ/Password
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53283] Add Support for Externalized Data Source Credentials
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53283
--- Comment #6 from Marvin Addison <ma...@gmail.com> ---
Actually, it was leveraging the system property replacement feature in the docs
you cited that led to this enhancement request. We were setting system
properties in setenv.sh, but then discovered that had the very undesirable
consequence of leaking sensitive data to anyone on the system via ps output.
While I could have engineered a valve or something to set system properties
more discretely, storing credentials in a global, long-term facility seemed
less desirable than a more targeted solution.
The patch here is about 20 lines and adds reasonable value. I hope you'll
consider it. I'm happy to respond to feedback on the patch if that will
increase the likelihood of acceptance.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53283] Add Support for Externalized Data Source Credentials
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53283
--- Comment #3 from Marvin Addison <ma...@gmail.com> ---
I'm embarrassed if that's supported and I missed it. I took the time for a
thoughtful code review of jdbc-pool and didn't see what I was looking for, so
wrote a simple patch. If it's not too much trouble, I wonder if you'd quickly
review the patch to see if similar functionality is supported. If so I'll
follow up on list.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53283] Add Support for Externalized Data Source Credentials
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53283
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
This is already supported. Ask on the users list if you need help with
configuration.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org