[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and…
URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r341385501
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/deliveryServiceSslKeys/form.deliveryServiceSslKeys.tpl.html
 ##########
 @@ -41,39 +41,53 @@
         <br>
 
 Review comment:
   Finally, a manual navigation to `#!/delivery-services/{{ID}}/ssl-keys/generate` triggers two XHR requests:
   • `/api/1.4/deliveryservices/{{ID}}`
       returns: The full DS as expected
   • `/api/1.4/deliveryservices/xmlid/{{xmlid}}/sslkeys?decode=true`
       returns:
   ```http
       HTTP/1.1 200 OK
       Content-Type: application/json
       Other-Headers: Omitted
   
       { "alerts": [{
           "text": "no object found for the specified key",
           "level": "info"
       }]}
   ```
   
   Which looks more like an error than an "info", and the page never loads but immediately redirects to `#!/delivery-services/{{ID}}/ssl-keys`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services