You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/06/13 22:32:09 UTC

[kudu-CR] [master] KUDU-2671 update partition schema in catalog on AlterTable

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18615


Change subject: [master] KUDU-2671 update partition schema in catalog on AlterTable
......................................................................

[master] KUDU-2671 update partition schema in catalog on AlterTable

When adding a range with custom hash schema to a table, it's necessary
to update the partition schema information stored in the system catalog
correspondingly.  That was missing in one of the previous patches and
this patch addresses the issue.

This patch also adds a test scenario to spot regressions, if any.  The
scenario was failing before the update in CatalogManager introduced
in this patch.

This is a follow-up to 250eb90bc0e1f4f472f44de8a23ce213595d5ee7.

Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master-test.cc
3 files changed, 164 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/18615/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] KUDU-2671 update partition schema in catalog when adding range

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Tidy Bot, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18615

to look at the new patch set (#2).

Change subject: KUDU-2671 update partition schema in catalog when adding range
......................................................................

KUDU-2671 update partition schema in catalog when adding range

When adding a range with custom hash schema to a table, it's necessary
to update the partition schema information stored in the system catalog
correspondingly.  That was missing in one of the previous patches and
this patch addresses the issue.

This patch also adds a test scenario to spot regressions, if any.  The
scenario was failing before the update in CatalogManager introduced
in this patch.  I also addressed nits pointed to by the TidyBot.

This is a follow-up to 250eb90bc0e1f4f472f44de8a23ce213595d5ee7.

Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master-test.cc
3 files changed, 180 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/18615/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [master] KUDU-2671 update partition schema in catalog on AlterTable

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: [master] KUDU-2671 update partition schema in catalog on AlterTable
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18615/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18615/1/src/kudu/master/catalog_manager.cc@2606
PS1, Line 2606:     vector<AlterTableRequestPB::Step> steps,
> warning: the parameter 'steps' is copied for each invocation but only used 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 14 Jun 2022 02:15:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] KUDU-2671 update partition schema in catalog on AlterTable

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [master] KUDU-2671 update partition schema in catalog on AlterTable
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2671 update partition schema in catalog when adding range

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: KUDU-2671 update partition schema in catalog when adding range
......................................................................


Patch Set 2: Code-Review+1

Thanks for fixing this.


-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 14 Jun 2022 03:35:12 +0000
Gerrit-HasComments: No

[kudu-CR] [master] KUDU-2671 update partition schema in catalog on AlterTable

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: [master] KUDU-2671 update partition schema in catalog on AlterTable
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18615/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18615/1/src/kudu/master/catalog_manager.cc@2679
PS1, Line 2679:       // Add information on the new range with custom hash schema into the
Similarly, will there be a follow up patch for updating the PartitionSchema for the table stored in system catalog when dropping a range?



-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 13 Jun 2022 23:20:39 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2671 update partition schema in catalog when adding range

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: KUDU-2671 update partition schema in catalog when adding range
......................................................................

KUDU-2671 update partition schema in catalog when adding range

When adding a range with custom hash schema to a table, it's necessary
to update the partition schema information stored in the system catalog
correspondingly.  That was missing in one of the previous patches and
this patch addresses the issue.

This patch also adds a test scenario to spot regressions, if any.  The
scenario was failing before the update in CatalogManager introduced
in this patch.  I also addressed nits pointed to by the TidyBot.

This is a follow-up to 250eb90bc0e1f4f472f44de8a23ce213595d5ee7.

Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Reviewed-on: http://gerrit.cloudera.org:8080/18615
Tested-by: Kudu Jenkins
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master-test.cc
3 files changed, 180 insertions(+), 27 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Mahesh Reddy: Looks good to me, but someone else must approve
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2671 update partition schema in catalog when adding range

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: KUDU-2671 update partition schema in catalog when adding range
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 16 Jun 2022 11:17:01 +0000
Gerrit-HasComments: No

[kudu-CR] [master] KUDU-2671 update partition schema in catalog on AlterTable

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: [master] KUDU-2671 update partition schema in catalog on AlterTable
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

> Patch Set 1:
> 
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/18615/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18615/1/src/kudu/master/catalog_manager.cc@2679
PS1, Line 2679:       // Add information on the new range with custom hash schema into the
> Right: there should be a patch to address dropping a range.
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 14 Jun 2022 02:16:49 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2671 update partition schema in catalog when adding range

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: KUDU-2671 update partition schema in catalog when adding range
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 15 Jun 2022 19:25:50 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 update partition schema in catalog when adding range

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: KUDU-2671 update partition schema in catalog when adding range
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 14 Jun 2022 17:36:32 +0000
Gerrit-HasComments: No

[kudu-CR] [master] KUDU-2671 update partition schema in catalog on AlterTable

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: [master] KUDU-2671 update partition schema in catalog on AlterTable
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18615/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18615/1/src/kudu/master/catalog_manager.cc@2679
PS1, Line 2679:       // Add information on the new range with custom hash schema into the
> Similarly, will there be a follow up patch for updating the PartitionSchema
Right: there should be a patch to address dropping a range.

However, that's more changes, and I'd like to keep it separate for the ease or reviewing and tracking the changes.



-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 14 Jun 2022 02:11:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] KUDU-2671 update partition schema in catalog on AlterTable

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18615 )

Change subject: [master] KUDU-2671 update partition schema in catalog on AlterTable
......................................................................


Patch Set 1: Verified+1

unrelated test failure: DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota


-- 
To view, visit http://gerrit.cloudera.org:8080/18615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I869458fb8bcb06801b54f2b4869e7826322563e0
Gerrit-Change-Number: 18615
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 14 Jun 2022 02:11:15 +0000
Gerrit-HasComments: No