You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2025/06/14 02:09:33 UTC
[PR] added timeout for Direct_Read with Bigquery IO [beam]
liferoad opened a new pull request, #35284:
URL: https://github.com/apache/beam/pull/35284
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added timeout for Direct_Read with Bigquery IO [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #35284:
URL: https://github.com/apache/beam/pull/35284#discussion_r2150898042
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1327,7 +1335,8 @@ def read_avro(self):
read_rows_iterator = iter(
storage_client.read_rows(
self.read_stream_name,
- retry_delay_callback=self.retry_delay_callback))
+ retry_delay_callback=self.retry_delay_callback,
+ timeout=self.timeout))
Review Comment:
bigquery read api uses `86400.0`, which is 1 day. Do we think it is reasonable? @kmjung
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added timeout for Direct_Read with Bigquery IO [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm commented on code in PR #35284:
URL: https://github.com/apache/beam/pull/35284#discussion_r2150466200
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1327,7 +1335,8 @@ def read_avro(self):
read_rows_iterator = iter(
storage_client.read_rows(
self.read_stream_name,
- retry_delay_callback=self.retry_delay_callback))
+ retry_delay_callback=self.retry_delay_callback,
+ timeout=self.timeout))
Review Comment:
Got it. Even in batch pipeline it will retry? I thought bundle retries are only done in streaming pipelines by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added timeout for Direct_Read with Bigquery IO [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #35284:
URL: https://github.com/apache/beam/pull/35284#discussion_r2150872017
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1327,7 +1335,8 @@ def read_avro(self):
read_rows_iterator = iter(
storage_client.read_rows(
self.read_stream_name,
- retry_delay_callback=self.retry_delay_callback))
+ retry_delay_callback=self.retry_delay_callback,
+ timeout=self.timeout))
Review Comment:
Previously it defaults to google.api_core.gapic_v1.method.DEFAULT, now defaults to 1 h. Wouldn't it break legit use case of long running read operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added timeout for Direct_Read with Bigquery IO [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #35284:
URL: https://github.com/apache/beam/pull/35284#discussion_r2150837155
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1327,7 +1335,8 @@ def read_avro(self):
read_rows_iterator = iter(
storage_client.read_rows(
self.read_stream_name,
- retry_delay_callback=self.retry_delay_callback))
+ retry_delay_callback=self.retry_delay_callback,
+ timeout=self.timeout))
Review Comment:
batch for failed work items should retry up to 4 times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added timeout for Direct_Read with Bigquery IO [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad merged PR #35284:
URL: https://github.com/apache/beam/pull/35284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added timeout for Direct_Read with Bigquery IO [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35284:
URL: https://github.com/apache/beam/pull/35284#issuecomment-2972221813
Assigning reviewers:
R: @jrmccluskey for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added timeout for Direct_Read with Bigquery IO [beam]
Posted by "claudevdm (via GitHub)" <gi...@apache.org>.
claudevdm commented on code in PR #35284:
URL: https://github.com/apache/beam/pull/35284#discussion_r2150441490
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1327,7 +1335,8 @@ def read_avro(self):
read_rows_iterator = iter(
storage_client.read_rows(
self.read_stream_name,
- retry_delay_callback=self.retry_delay_callback))
+ retry_delay_callback=self.retry_delay_callback,
+ timeout=self.timeout))
Review Comment:
What happens when the read times out here? Will the pipeline fail faster, or will the specific read be retried? If it is retried, will we be able to recover from a stream that has been cancelled (meaning the work is sent to a different worker that references a different stream)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added timeout for Direct_Read with Bigquery IO [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #35284:
URL: https://github.com/apache/beam/pull/35284#discussion_r2150446466
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1327,7 +1335,8 @@ def read_avro(self):
read_rows_iterator = iter(
storage_client.read_rows(
self.read_stream_name,
- retry_delay_callback=self.retry_delay_callback))
+ retry_delay_callback=self.retry_delay_callback,
+ timeout=self.timeout))
Review Comment:
From what I understand, this will be retried using `retry_delay_callback`. If the retries fail eventually, the whole bundle should fail and retried with a new stream. cc @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added timeout for Direct_Read with Bigquery IO [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #35284:
URL: https://github.com/apache/beam/pull/35284#discussion_r2155155985
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -1327,7 +1335,8 @@ def read_avro(self):
read_rows_iterator = iter(
storage_client.read_rows(
self.read_stream_name,
- retry_delay_callback=self.retry_delay_callback))
+ retry_delay_callback=self.retry_delay_callback,
+ timeout=self.timeout))
Review Comment:
Can we relay to the client default if it is not provided, that is the client behavior. The point is that we now always overwrites clients' default which is not necessary in most cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org