[GitHub] [iceberg] nastra commented on a diff in pull request #7336: API: Update java doc for listTables and listViews

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7336:
URL: https://github.com/apache/iceberg/pull/7336#discussion_r1182458583


##########
api/src/main/java/org/apache/iceberg/catalog/ViewCatalog.java:
##########
@@ -41,7 +41,8 @@ public interface ViewCatalog {
    *
    * @param namespace a namespace
    * @return a list of identifiers for views
-   * @throws NotFoundException if the namespace is not found
+   * @throws NoSuchNamespaceException if the namespace is not found
+   * @throws IllegalArgumentException if the namespace is invalid for the catalog

Review Comment:
   is this true for all catalogs?



##########
api/src/main/java/org/apache/iceberg/catalog/Catalog.java:
##########
@@ -46,7 +46,8 @@ default String name() {
    *
    * @param namespace a namespace
    * @return a list of identifiers for tables
-   * @throws NotFoundException if the namespace is not found
+   * @throws NoSuchNamespaceException if the namespace is not found
+   * @throws IllegalArgumentException if the namespace is invalid for the catalog

Review Comment:
   is this true for all catalogs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org