You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/02 21:59:59 UTC

[GitHub] [spark] srowen commented on issue #25032: Add root degree to PolynomialExpansion

srowen commented on issue #25032: Add root degree to PolynomialExpansion
URL: https://github.com/apache/spark/pull/25032#issuecomment-507860781
 
 
   I think the main purpose of the polynomial expansion support is to generate interaction terms like "x * y". This only generates fractional powers of an input. I doubt that anything but square root would be useful in almost all cases? so I doubt this is worth adding to the API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org