You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/06/03 07:23:27 UTC
[GitHub] [avro] iemejia opened a new pull request #1246: AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version
iemejia opened a new pull request #1246:
URL: https://github.com/apache/avro/pull/1246
The maven-maven-plugin upgrade is just to fix a maven issue when building with Java 17, sadly there seems not to be a 3.8.x version to keep them aligned yet.
R: @RyanSkraba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on a change in pull request #1246: AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #1246:
URL: https://github.com/apache/avro/pull/1246#discussion_r644717822
##########
File path: lang/java/pom.xml
##########
@@ -347,7 +347,6 @@
<pluginExecutionFilter>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <versionRange>[${plugin-plugin.version},)</versionRange>
Review comment:
Huh .. is this even defined someplace? Glad to get rid of it, I guess!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on a change in pull request #1246: AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #1246:
URL: https://github.com/apache/avro/pull/1246#discussion_r644717822
##########
File path: lang/java/pom.xml
##########
@@ -347,7 +347,6 @@
<pluginExecutionFilter>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <versionRange>[${plugin-plugin.version},)</versionRange>
Review comment:
Huh .. is this even defined someplace? Glad to get rid of it, I guess!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1246: AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1246:
URL: https://github.com/apache/avro/pull/1246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1246: AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1246:
URL: https://github.com/apache/avro/pull/1246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia commented on a change in pull request #1246: AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version
Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #1246:
URL: https://github.com/apache/avro/pull/1246#discussion_r644744950
##########
File path: lang/java/pom.xml
##########
@@ -347,7 +347,6 @@
<pluginExecutionFilter>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <versionRange>[${plugin-plugin.version},)</versionRange>
Review comment:
No, it wasn't! that's why it was looking an older version and breaking the build on Java 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia commented on a change in pull request #1246: AVRO-3120: Upgrade maven-maven-plugin and spotless to a more recent version
Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #1246:
URL: https://github.com/apache/avro/pull/1246#discussion_r644744950
##########
File path: lang/java/pom.xml
##########
@@ -347,7 +347,6 @@
<pluginExecutionFilter>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
- <versionRange>[${plugin-plugin.version},)</versionRange>
Review comment:
No, it wasn't! that's why it was looking an older version and breaking the build on Java 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org