[jira] Commented: (MATH-242) Missing tests in MathUtilsTest

["Christian Semrau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MATH-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665583#action_12665583 ] 

Christian Semrau commented on MATH-242:
---------------------------------------

After thinking a bit longer, I think the gcd method should throw an Exception for gcd(Integer.MIN_VALUE, 0) too, like for gcd(Integer.MIN_VALUE, Integer.MIN_VALUE). So my patch verifies the current behaviour, but I suggest changing that: gcd should only return nonnegative results (a result of 0 can come from gcd(0,0)).


> Missing tests in MathUtilsTest
> ------------------------------
>
>                 Key: MATH-242
>                 URL: https://issues.apache.org/jira/browse/MATH-242
>             Project: Commons Math
>          Issue Type: Test
>    Affects Versions: 2.0
>            Reporter: Christian Semrau
>            Priority: Minor
>         Attachments: MathUtilsTestPatch.txt
>
>
> Using EclEmma, I spotted some methods and special cases in MathUtils that were not tested. I will attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.