[jira] [Reopened] (HTTPCLIENT-1960) URIBuilder does not handle absolute path values

["Raymond Cuenen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raymond Cuenen reopened HTTPCLIENT-1960:
----------------------------------------

There should be a function added to set an "escaped" path instead of only "unescaped" paths

> URIBuilder does not handle absolute path values
> -----------------------------------------------
>
>                 Key: HTTPCLIENT-1960
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1960
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (async), HttpClient (classic)
>    Affects Versions: 4.5.5
>            Reporter: Raymond Cuenen
>            Priority: Major
>
> If original path startsWith '/' it is removed by normalizePath; in that case it should be added again URI-encoded. For example: A path value of '/etc/motd' becomes:
> {code:java}
> ftp://myname@host.dom/etc/motd{code}
> while it should be:
> {code:java}
> ftp://myname@host.dom/%2Fetc/motd{code}
> Only when the path value is 'etc/motd' is should become "ftp://myname@host.dom/etc/motd"
>   
> Fix for this issue in URIBuilder.java:
> {noformat}
> private String buildString() {
> ...
>     if (this.encodedPath != null) {
>         sb.append(normalizePath(this.encodedPath, sb.length() == 0));
>     } else if (this.path != null) {
>         String encodedPath = encodePath(normalizePath(this.path, sb.length() == 0));
>         // Start fix for paths starting with '/'
>         // If original path startsWith '/' it is removed by normalizePath; in that case it should be added again URI-encoded.
>         if (this.path.startsWith("/")) {
>             encodedPath = "/%2F" + encodedPath.substring(1);
>         }
>         // End fix
>         sb.append(encodedPath);
>     }
> ...
> }{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org