You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens-G <gi...@git.apache.org> on 2017/03/26 19:27:38 UTC
[GitHub] thrift pull request #1223: THRIFT-4137 vptr @ compiler
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1223
THRIFT-4137 vptr @ compiler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4137
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1223
----
commit 4dca9e6b256fa831689e386abf09471867a2e009
Author: Jens Geyer <je...@apache.org>
Date: 2017-03-26T12:52:35Z
THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch
commit 0d3cc7204d2d531623f35624e80a83c91b03c8e8
Author: Jens Geyer <je...@apache.org>
Date: 2017-03-26T15:27:59Z
THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch
commit e67ee35eadb62774fdf967e332d9bc6711a0177e
Author: Jens Geyer <je...@apache.org>
Date: 2017-03-26T17:41:24Z
THRIFT-4134 Fix remaining undefined behavior invalid vptr
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1223: THRIFT-4137 vptr @ compiler
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1223
Yeah, but at least it looks as if we get the compiler ready.
If there are no objections, I am going commit that part today, With UBSAN still left disabled of course. I only enabled it in the PR to have travis run these tests.
Since you already made some proposals, could you take care about the boost / libraries part? @jeking3 and me will be happy reviewers, that's for sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1223: THRIFT-4137 vptr @ compiler
Posted by jbapple-cloudera <gi...@git.apache.org>.
Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1223
@jeking3 It looks to me like this is failing in TravisCI at the UBSan test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1223: THRIFT-4137 vptr @ compiler
Posted by jbapple-cloudera <gi...@git.apache.org>.
Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1223
I can take a look at the Boost problem next weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1223: THRIFT-4137 vptr @ compiler
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---