You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xianjingfeng (via GitHub)" <gi...@apache.org> on 2023/03/25 13:07:14 UTC
[GitHub] [incubator-uniffle] xianjingfeng opened a new pull request, #764: [MINOR] chore(operator): remove useless configuration items in configuration example
xianjingfeng opened a new pull request, #764:
URL: https://github.com/apache/incubator-uniffle/pull/764
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Remove useless configuration items in configuration example.
### Why are the changes needed?
The configuration items that removed will be generated automatically. Setting them has no effect.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng merged pull request #764: [MINOR] chore(operator): remove useless configuration items in configuration example
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng merged PR #764:
URL: https://github.com/apache/incubator-uniffle/pull/764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #764: [MINOR] chore(operator): remove useless configuration items in configuration example
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #764:
URL: https://github.com/apache/incubator-uniffle/pull/764#issuecomment-1483821318
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/764?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#764](https://codecov.io/gh/apache/incubator-uniffle/pull/764?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe2d23b) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/567872b8c89a19c16e31c7919ab196fe7568c02a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (567872b) will **increase** coverage by `1.13%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #764 +/- ##
============================================
+ Coverage 60.67% 61.81% +1.13%
+ Complexity 1901 1795 -106
============================================
Files 239 214 -25
Lines 13031 10447 -2584
Branches 1091 1042 -49
============================================
- Hits 7907 6458 -1449
+ Misses 4686 3631 -1055
+ Partials 438 358 -80
```
[see 27 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/764/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #764: [MINOR] chore(operator): remove useless configuration items in configuration example
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #764:
URL: https://github.com/apache/incubator-uniffle/pull/764#discussion_r1148371794
##########
deploy/kubernetes/operator/examples/configuration.yaml:
##########
@@ -42,11 +42,8 @@ data:
log4j.appender.RollingAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.RollingAppender.layout.ConversionPattern=[%p] %d %t %c{1} %M - %m%n
server.conf: |-
- rss.coordinator.quorum rss-coordinator-rss-demo-0:19997,rss-coordinator-rss-demo-1:19997
Review Comment:
How about make this configuration commented out? such as
```
# these configurations are generated by operator automatically
# rss.coordinator.quorum rss-coordinator-rss-demo-0:19997,rss-coordinator-rss-demo-1:19997
# ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #764: [MINOR] chore(operator): remove useless configuration items in configuration example
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on code in PR #764:
URL: https://github.com/apache/incubator-uniffle/pull/764#discussion_r1148468713
##########
deploy/kubernetes/operator/examples/configuration.yaml:
##########
@@ -42,11 +42,8 @@ data:
log4j.appender.RollingAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.RollingAppender.layout.ConversionPattern=[%p] %d %t %c{1} %M - %m%n
server.conf: |-
- rss.coordinator.quorum rss-coordinator-rss-demo-0:19997,rss-coordinator-rss-demo-1:19997
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org