You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by athanatos <gi...@git.apache.org> on 2017/04/10 19:26:25 UTC
[GitHub] bookkeeper pull request #130: BOOKKEEPER-1031: close the ledger handle in Re...
GitHub user athanatos opened a pull request:
https://github.com/apache/bookkeeper/pull/130
BOOKKEEPER-1031: close the ledger handle in ReplicationWorker.rerepli\u2026
\u2026cate
Otherwise, we build up an unbounded set of Listeners in the
AbstractZkLedgerManager listenerSet structure which never go
away.
Signed-off-by: Samuel Just <sj...@salesforce.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/athanatos/bookkeeper forupstream/BOOKKEEPER-1031
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit f5f595b1aadbef6d36b29d2f93de7cb3bcdb67ca
Author: Samuel Just <sj...@salesforce.com>
Date: 2017-04-05T21:12:58Z
BOOKKEEPER-1031: close the ledger handle in ReplicationWorker.rereplicate
Otherwise, we build up an unbounded set of Listeners in the
AbstractZkLedgerManager listenerSet structure which never go
away.
Signed-off-by: Samuel Just <sj...@salesforce.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/130
@athanatos I think those two are known failures. I think @eolivelli knew about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...
Posted by athanatos <gi...@git.apache.org>.
Github user athanatos commented on the issue:
https://github.com/apache/bookkeeper/pull/130
Build's failing due to
Tests in error:
BookieRecoveryTest.ensurePasswordUsedForOldLedgers[4] � BKNoSuchLedgerExists
BookieRecoveryTest.ensurePasswordUsedForOldLedgers[5] � BKNoSuchLedgerExists
which seems to be broken in master.
I did a bisect and found that
https://github.com/apache/bookkeeper/commit/42e8f1294f206cbe51a6af669cf605833b78bf42 introduced both a hang in that test and that test failure. https://github.com/apache/bookkeeper/commit/32ebf0ad68f85daffdec571e28206339a4d09443 fixed the hang uncovering the test failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/130
@sijie can you add Samuel to the contributors in JIRA so that the issue can be assigned to him?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper pull request #130: BOOKKEEPER-1031: close the ledger handle in Re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bookkeeper/pull/130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...
Posted by athanatos <gi...@git.apache.org>.
Github user athanatos commented on the issue:
https://github.com/apache/bookkeeper/pull/130
Cool, what's the next step?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/130
merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/130
We are going to merge as soon as possible. Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---