[GitHub] [iceberg] rdblue commented on a change in pull request #2826: Build: Upgrade to Gradle 7.x

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r675667832



##########
File path: api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java
##########
@@ -429,7 +429,7 @@ public Boolean or(Boolean leftResult, Boolean rightResult) {
     }
 
     private boolean canContainNulls(Integer id) {
-      return nullCounts == null || (nullCounts.containsKey(id) && nullCounts.get(id) > 0);
+      return nullCounts == null || nullCounts.containsKey(id) && nullCounts.get(id) > 0;

Review comment:
       I think it is much better to have the parentheses so that the logic is clear to a reader, even if it is identical to Java's precedence. Can you update the style config and revert these changes?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org