You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/14 15:24:32 UTC

[GitHub] zhaojiandong commented on a change in pull request #6365: new feature: allows user to specify timeZone in TimestampSpec

zhaojiandong commented on a change in pull request #6365: new feature: allows user to specify timeZone in TimestampSpec
URL: https://github.com/apache/incubator-druid/pull/6365#discussion_r256879747
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/java/util/common/parsers/TimestampParser.java
 ##########
 @@ -87,7 +87,7 @@
       };
     } else {
       try {
-        final DateTimes.UtcFormatter formatter = DateTimes.wrapFormatter(DateTimeFormat.forPattern(format));
+        final DateTimes.Formatter formatter = DateTimes.wrapFormatter(format, userTimeZone);
 
 Review comment:
   I've changed implement of DateTimes.wrapFormatter, added a param timezone. And wrapper the DateTimeFormat.forPattern into the class DateTimes$Formatter. @clintropolis 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org