You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/04/02 14:43:18 UTC

[GitHub] [camel-k] astefanutti opened a new pull request #2190: fix: Add bindings.knative.dev/include label to SinkBinding sources

astefanutti opened a new pull request #2190:
URL: https://github.com/apache/camel-k/pull/2190


   This PR makes sure the Eventing webhook will select the source resource, in order to inject the sink information.
   
   This is necessary for Knative environments, that are configured with `SINK_BINDING_SELECTION_MODE=inclusion`. See:
   - https://knative.dev/v0.20-docs/eventing/sources/sinkbinding/
   - https://github.com/knative/operator/blob/c60e62bb86ff318c44d1520927d2182659cfdeb5/docs/configuration.md#specsinkbindingselectionmode
   
   Fixes #2184.
   
   **Release Note**
   ```release-note
   fix: Add bindings.knative.dev/include label to SinkBinding sources
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] astefanutti merged pull request #2190: fix: Add bindings.knative.dev/include label to SinkBinding sources

Posted by GitBox <gi...@apache.org>.

astefanutti merged pull request #2190:
URL: https://github.com/apache/camel-k/pull/2190


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] astefanutti commented on pull request #2190: fix: Add bindings.knative.dev/include label to SinkBinding sources

Posted by GitBox <gi...@apache.org>.

astefanutti commented on pull request #2190:
URL: https://github.com/apache/camel-k/pull/2190#issuecomment-820574240


   I should also fix #1945.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] astefanutti edited a comment on pull request #2190: fix: Add bindings.knative.dev/include label to SinkBinding sources

Posted by GitBox <gi...@apache.org>.

astefanutti edited a comment on pull request #2190:
URL: https://github.com/apache/camel-k/pull/2190#issuecomment-820574240


   It should also fix #1945.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org