You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Sun-GLiang (via GitHub)" <gi...@apache.org> on 2026/08/29 07:35:03 UTC

[I] test: full suite depends on macOS path spelling and persistent tmp state [maka]

Sun-GLiang opened a new issue, #4139:
URL: https://github.com/apache/maka/issues/4139

   ## What happened
   
   The repository test suite has three stable environment-dependent failures on macOS at current `main` (`82b36dc6d`). They are unrelated to application behavior but prevent a clean local `npm test` result:
   
   1. `packages/runtime/src/__tests__/deep-research-tools.test.ts` opens the fixed directory `/tmp/maka-unused-deep-research-2`. A database left by an older operational schema fails with `OperationalStateMigrationBlockedError` for `table:message_admissions`.
   2. `packages/runtime/src/__tests__/builtin-tools.test.ts` requires `/usr/local` to be `EXECUTABLE_ROOT_1`. When Node is `/usr/local/bin/node`, root deduplication correctly leaves `/usr/local` at index 0.
   3. `packages/cli/src/__tests__/runtime-host-setup.test.ts` compares lexical `/var/folders/...` paths with canonical `/private/var/folders/...` paths. This causes both `deployment_claim_mismatch` and a deployment-root equality failure.
   
   Expected behavior: tests should use isolated temporary state and assert canonical path or root membership semantics without depending on a platform-specific spelling or array index.
   
   ## How to reproduce
   
   On macOS with Node installed at `/usr/local/bin/node`:
   
   1. Check out current `main` and build the affected workspaces.
   2. Run:
   
   ```sh
   npm --workspace @maka/runtime run build
   npm --workspace maka-agent run build
   node --test --test-name-pattern="canonicalizes macOS Bash cwd and exposes the runtime executable roots" packages/runtime/dist/__tests__/builtin-tools.test.js
   node --test packages/runtime/dist/__tests__/deep-research-tools.test.js
   node --test packages/cli/dist/__tests__/runtime-host-setup.test.js
   ```
   
   For the Deep Research failure, `/tmp/maka-unused-deep-research-2` must contain an operational database created by an older schema. This is normal after repeated development runs across schema changes.
   
   Observed failures:
   
   - `argv.includes("-DEXECUTABLE_ROOT_1=/usr/local")` is false.
   - `Incomplete operational SQLite schema: schema object table:message_admissions has an incompatible definition`.
   - `The managed Runtime Host does not match the expected deployment identity`.
   - Expected `/var/folders/...`, received `/private/var/folders/...`.
   
   ## Environment
   
   - Maka commit: `82b36dc6d`
   - OS: macOS 15.6 (24G84)
   - Surface: Runtime and CLI test suites
   - Node.js: v24.19.0
   
   ## Logs, screenshots, or additional context
   
   Suggested test-only corrections:
   
   - Replace the fixed Deep Research database directory with `mkdtemp` plus cleanup.
   - Assert that the Seatbelt arguments contain an executable-root definition whose value is `/usr/local`, regardless of index.
   - Compare CLI deployment paths after `realpath`, and use the canonical persisted root when constructing `expectedTarget`.
   
   The detached-descendant shell test also failed once under the parallel root runner, but passed on an isolated rerun and is intentionally excluded from this report pending a stable reproduction.
   
   This was discovered while validating a UI-only follow-up to #3880. The UI change does not touch Runtime, Storage, or CLI code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [I] test: full suite depends on macOS path spelling and persistent tmp state [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #4139: test: full suite depends on macOS path spelling and persistent tmp state
URL: https://github.com/apache/maka/issues/4139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [I] test: full suite depends on macOS path spelling and persistent tmp state [maka]

Posted by "Sun-GLiang (via GitHub)" <gi...@apache.org>.
Sun-GLiang commented on issue #4139:
URL: https://github.com/apache/maka/issues/4139#issuecomment-5461093276

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org