[GitHub] [airflow] mik-laj commented on a change in pull request #16612: AWS Hook - allow IDP HTTP retry (#12639)

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #16612:
URL: https://github.com/apache/airflow/pull/16612#discussion_r657430991



##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -214,18 +216,42 @@ def _assume_role_with_saml(
             RoleArn=role_arn, PrincipalArn=principal_arn, SAMLAssertion=saml_assertion, **assume_role_kwargs
         )
 
-    def _fetch_saml_assertion_using_http_spegno_auth(self, saml_config: Dict[str, Any]) -> str:
-        import requests
+    def _get_idp_response(
+        self, saml_config: Dict[str, Any], auth: requests.auth.AuthBase
+    ) -> requests.models.Response:
+        idp_url = saml_config["idp_url"]
+        self.log.info("idp_url= %s", idp_url)
+
+        session = requests.Session()
+

Review comment:
       Can you add this to docs?
   http://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/connections/aws.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org