You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Croway (via GitHub)" <gi...@apache.org> on 2023/05/15 10:56:59 UTC

[GitHub] [camel] Croway opened a new pull request, #10083: CAMEL-19352: improve mybatis doc

Croway opened a new pull request, #10083:
URL: https://github.com/apache/camel/pull/10083

   # Description
   
   <!--
   - Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   -->
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful subject line and body.
   
   <!--  
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   -->
   
   - [ ] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
   
   <!-- 
   You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
   
   You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #10083: CAMEL-19352: improve mybatis doc

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10083:
URL: https://github.com/apache/camel/pull/10083#issuecomment-1547709539

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 0 | 1 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #10083: CAMEL-19352: improve mybatis doc

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10083:
URL: https://github.com/apache/camel/pull/10083#issuecomment-1547636730

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
   
   :warning: Please note that the changes on this PR may be **tested automatically** if they change components.
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #10083: CAMEL-19352: improve mybatis doc

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #10083:
URL: https://github.com/apache/camel/pull/10083


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #10083: CAMEL-19352: improve mybatis doc

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10083:
URL: https://github.com/apache/camel/pull/10083#issuecomment-1547966125

   its easy you just need to mark it in the annotation, such as
   https://github.com/apache/camel/blob/main/components/camel-sql/src/main/java/org/apache/camel/component/sql/SqlComponent.java#L39


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #10083: CAMEL-19352: improve mybatis doc

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10083:
URL: https://github.com/apache/camel/pull/10083#issuecomment-1547672582

   I wonder if 
   
   > camel.component.mybatis.sql-session-factory=#sqlSessionFactory
   
   We should make Camel mybatis component have autowried for SqlSessionFactory, then it would automatic detect the mybatis-spring-boot configured and use it OOTB. We do this for some of the other components.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] Croway commented on pull request #10083: CAMEL-19352: improve mybatis doc

Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway commented on PR #10083:
URL: https://github.com/apache/camel/pull/10083#issuecomment-1547870400

   > I wonder if
   > 
   > > camel.component.mybatis.sql-session-factory=#sqlSessionFactory
   > 
   > We should make Camel mybatis component have autowried for SqlSessionFactory, then it would automatic detect the mybatis-spring-boot configured and use it OOTB. We do this for some of the other components.
   
   Yes, this would be great, may you provide an example?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org