You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/07/01 19:58:26 UTC

Re: Review Request 70904: Added tests for task killing when draining the agent.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70904/
-----------------------------------------------------------

(Updated July 1, 2019, 7:58 p.m.)


Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9821
    https://issues.apache.org/jira/browse/MESOS-9821


Repository: mesos


Description
-------

Added tests for task killing when draining the agent.


Diffs (updated)
-----

  src/tests/slave_tests.cpp 5d930bd81c349d11fa980433f2541a2f968ddeb0 


Diff: https://reviews.apache.org/r/70904/diff/3/

Changes: https://reviews.apache.org/r/70904/diff/2-3/


Testing
-------

`make check`
`bin/mesos-tests.sh --gtest_filter="*DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann


Re: Review Request 70904: Added tests for task killing when draining the agent.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70904/#review216568
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On July 1, 2019, 12:58 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70904/
> -----------------------------------------------------------
> 
> (Updated July 1, 2019, 12:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9821
>     https://issues.apache.org/jira/browse/MESOS-9821
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for task killing when draining the agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 5d930bd81c349d11fa980433f2541a2f968ddeb0 
> 
> 
> Diff: https://reviews.apache.org/r/70904/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> `bin/mesos-tests.sh --gtest_filter="*DrainAgent*" --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>