You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/05/06 13:53:48 UTC
[kudu-CR] KUDU-2812: Fix error reporting in KuduRestore
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13244
Change subject: KUDU-2812: Fix error reporting in KuduRestore
......................................................................
KUDU-2812: Fix error reporting in KuduRestore
Before this patch, calls to
`session.getPendingErrors.getRowErrors.length`
would clear the errors buffer before we called it again
to report the errors.
This patch ensures we capture the result of
`session.getPendingErrors` before checking the length.
Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/13244/1
--
To view, visit http://gerrit.cloudera.org:8080/13244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Gerrit-Change-Number: 13244
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2812: Fix error reporting in KuduRestore
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13244 )
Change subject: KUDU-2812: Fix error reporting in KuduRestore
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13244/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala:
http://gerrit.cloudera.org:8080/#/c/13244/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@127
PS1, Line 127: because each call to session.getPendingErrors clears the ErrorCollector.
> yeah, I had thought about renaming it too. I think this would be a good fol
If the collector overflows then more than `errors.length` rows had problems, so we ought to adjust the error message in the case of overflow.
--
To view, visit http://gerrit.cloudera.org:8080/13244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Gerrit-Change-Number: 13244
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 06 May 2019 14:58:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2812: Fix error reporting in KuduRestore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13244
to look at the new patch set (#2).
Change subject: KUDU-2812: Fix error reporting in KuduRestore
......................................................................
KUDU-2812: Fix error reporting in KuduRestore
Before this patch, calls to
`session.getPendingErrors.getRowErrors.length`
would clear the errors buffer before we called it again
to report the errors.
This patch ensures we capture the result of
`session.getPendingErrors` before checking the length.
Note: This patch also updates the message format for
both kudu-backup and kudu-spark.
Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
2 files changed, 25 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/13244/2
--
To view, visit http://gerrit.cloudera.org:8080/13244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Gerrit-Change-Number: 13244
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2812: Fix error reporting in KuduRestore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13244 )
Change subject: KUDU-2812: Fix error reporting in KuduRestore
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13244/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala:
http://gerrit.cloudera.org:8080/#/c/13244/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@127
PS1, Line 127: because each call to session.getPendingErrors clears the ErrorCollector.
> If the collector overflows then more than `errors.length` rows had problems
Done
--
To view, visit http://gerrit.cloudera.org:8080/13244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Gerrit-Change-Number: 13244
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 06 May 2019 17:38:42 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2812: Fix error reporting in KuduRestore
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13244 )
Change subject: KUDU-2812: Fix error reporting in KuduRestore
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13244/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala:
http://gerrit.cloudera.org:8080/#/c/13244/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@127
PS1, Line 127: because each call to session.getPendingErrors clears the ErrorCollector.
Yikes. I think we ought to deprecate getPendingErrors (since we can't just rename it) and add a new method with a name that makes clear that it is not just a getter. Maybe "getAndClearPendingErrors"?
Also, ought we to check the overflow status here too?
--
To view, visit http://gerrit.cloudera.org:8080/13244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Gerrit-Change-Number: 13244
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 06 May 2019 14:24:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2812: Fix error reporting in KuduRestore
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13244 )
Change subject: KUDU-2812: Fix error reporting in KuduRestore
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Gerrit-Change-Number: 13244
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 06 May 2019 17:44:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2812: Fix error reporting in KuduRestore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13244 )
Change subject: KUDU-2812: Fix error reporting in KuduRestore
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13244/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala:
http://gerrit.cloudera.org:8080/#/c/13244/1/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@127
PS1, Line 127: because each call to session.getPendingErrors clears the ErrorCollector.
> Yikes. I think we ought to deprecate getPendingErrors (since we can't just
yeah, I had thought about renaming it too. I think this would be a good follow on change.
I don't think we need to check the overflow since any error is reason to throw the RuntimeException and we only display 5.
--
To view, visit http://gerrit.cloudera.org:8080/13244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Gerrit-Change-Number: 13244
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 06 May 2019 14:46:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2812: Fix error reporting in KuduRestore
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13244 )
Change subject: KUDU-2812: Fix error reporting in KuduRestore
......................................................................
Patch Set 1: Code-Review+1
Agreed with Will.
--
To view, visit http://gerrit.cloudera.org:8080/13244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Gerrit-Change-Number: 13244
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 06 May 2019 17:32:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2812: Fix error reporting in KuduRestore
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13244 )
Change subject: KUDU-2812: Fix error reporting in KuduRestore
......................................................................
KUDU-2812: Fix error reporting in KuduRestore
Before this patch, calls to
`session.getPendingErrors.getRowErrors.length`
would clear the errors buffer before we called it again
to report the errors.
This patch ensures we capture the result of
`session.getPendingErrors` before checking the length.
Note: This patch also updates the message format for
both kudu-backup and kudu-spark.
Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Reviewed-on: http://gerrit.cloudera.org:8080/13244
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
2 files changed, 25 insertions(+), 12 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadf3941614a4879a9f35d1df9ee0cea274711c94
Gerrit-Change-Number: 13244
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>