[jira] [Commented] (CLOUDSTACK-5358) API: synchronization on the object is broken

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877042#comment-13877042 ] 

ASF subversion and git services commented on CLOUDSTACK-5358:
-------------------------------------------------------------

Commit 8db0d83d1aff178845076a7ff9429d69ada81364 in branch refs/heads/4.3 from [~kelveny]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8db0d83 ]

CLOUDSTACK-5358: Bring back concurrency control in sync-queue management


> API: synchronization on the object is broken
> --------------------------------------------
>
>                 Key: CLOUDSTACK-5358
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5358
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.3.0
>            Reporter: Alena Prokharchyk
>            Assignee: Kelven Yang
>            Priority: Critical
>             Fix For: 4.3.0, 4.4.0
>
>
> There is a way to synchronize API commands on certain CS object. For example, when createFirewallRule is called, synchronization on the Network is being done, so the next command won't be processed till the last one is executed.  To enable it for the certain command, following methods have to be added to corresponding *Cmd class:
> @Override
>     public String getSyncObjType() {
>         return BaseAsyncCmd.networkSyncObject;
>     }
>     @Override
>     public Long getSyncObjId() {
>         return getIp().getAssociatedWithNetworkId();
>     }
> This logic got broken after the changes for vmSync got merged in. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)