You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/27 19:15:39 UTC

[GitHub] [apisix-website] KishaniKandasamy opened a new pull request #274: fix: add a bundle of good first issues links to homepage 

KishaniKandasamy opened a new pull request #274:
URL: https://github.com/apache/apisix-website/pull/274


   Fixes: #178
   
   Changes:
   
   update homepage
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #274: fix: add a bundle of good first issues links to homepage

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #274:
URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808910548


   good!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan merged pull request #274: fix: add a bundle of good first issues links to homepage

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #274:
URL: https://github.com/apache/apisix-website/pull/274


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on pull request #274: fix: add a bundle of good first issues links to homepage

Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #274:
URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808904115


   > LGTM, and needs @1502shivam-singh's review :)
   > 
   > ![image](https://user-images.githubusercontent.com/2106987/112740134-06bb8980-8fad-11eb-8ecb-88802047152b.png)
   
   Just one minor thing can you make that GitHub logo png center aligned vertically with some padding like below -
   ![image](https://user-images.githubusercontent.com/57267960/112755660-4743f300-8fff-11eb-97ba-83c0167512ba.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on pull request #274: fix: add a bundle of good first issues links to homepage

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #274:
URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808905764


   > > LGTM, and needs @1502shivam-singh's review :)
   > > ![image](https://user-images.githubusercontent.com/2106987/112740134-06bb8980-8fad-11eb-8ecb-88802047152b.png)
   > 
   > Just one minor thing can you make that GitHub logo png center aligned vertically with some padding like below -
   > ![image](https://user-images.githubusercontent.com/57267960/112755660-4743f300-8fff-11eb-97ba-83c0167512ba.png)
   
   yeah Sure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #274: fix: add a bundle of good first issues links to homepage

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #274:
URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808907716


   ![image](https://user-images.githubusercontent.com/2106987/112756550-508d8980-9018-11eb-9eae-c017cae01f8c.png)
   
   Hi, it looks like the icon is not aligned with text?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org