You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/28 10:23:55 UTC
[GitHub] [hive] asolimando opened a new pull request, #3254: [WIP] Master sonar analysis
asolimando opened a new pull request, #3254:
URL: https://github.com/apache/hive/pull/3254
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asolimando commented on pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
asolimando commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1200881487
Dear bot, please keep the PR open!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asolimando commented on a diff in pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch
Posted by GitBox <gi...@apache.org>.
asolimando commented on code in PR #3254:
URL: https://github.com/apache/hive/pull/3254#discussion_r880613711
##########
Jenkinsfile:
##########
@@ -245,6 +245,21 @@ fi
buildHive("install -Dtest=noMatches")
}
checkPrHead()
+ stage('Sonar') {
Review Comment:
At the moment this is meant to run only for the master branch (i.e., only after merging PRs), so I guess the additional time could be acceptable there, but your proposal is superior, let me try to comply to that, so that we are closer to have sonar analysis for dev branches too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak closed pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
zabetak closed pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
URL: https://github.com/apache/hive/pull/3254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on a diff in pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
zabetak commented on code in PR #3254:
URL: https://github.com/apache/hive/pull/3254#discussion_r941388635
##########
Jenkinsfile:
##########
@@ -304,6 +304,53 @@ tar -xzf packaging/target/apache-hive-*-nightly-*-src.tar.gz
}
}
}
+ branches['sonar'] = {
+ executorNode {
+ if(env.CHANGE_BRANCH == 'master') {
+ stage('Prepare') {
+ loadWS();
+ }
+ stage('Sonar') {
+ withCredentials([string(credentialsId: 'sonar', variable: 'SONAR_TOKEN')]) {
+ sh """#!/bin/bash -e
+ sw java 11 && . /etc/profile.d/java.sh
+ export MAVEN_OPTS=-Xmx5G
+ mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar \
+ -Dsonar.organization=apache \
+ -Dsonar.projectKey=apache_hive \
+ -Dsonar.host.url=https://sonarcloud.io \
+ -Dsonar.branch.name=${CHANGE_BRANCH} \
+ -DskipTests -Dit.skipTests -Dmaven.javadoc.skip
+ """
+ }
+ }
+ } else if(env.CHANGE_ID) {
+ stage('Prepare') {
+ loadWS();
+ }
+ stage('Sonar') {
+ withCredentials([string(credentialsId: 'sonar', variable: 'SONAR_TOKEN')]) {
+ sh """#!/bin/bash -e
+ sw java 11 && . /etc/profile.d/java.sh
+ export MAVEN_OPTS=-Xmx5G
+ mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar \
+ -Dsonar.organization=apache \
+ -Dsonar.projectKey=apache_hive \
+ -Dsonar.host.url=https://sonarcloud.io \
+ -Dsonar.pullrequest.github.repository=apache/hive \
+ -Dsonar.pullrequest.key=${CHANGE_ID} \
+ -Dsonar.pullrequest.branch=${CHANGE_BRANCH} \
+ -Dsonar.pullrequest.base=${CHANGE_TARGET} \
+ -Dsonar.pullrequest.provider=GitHub \
+ -DskipTests -Dit.skipTests -Dmaven.javadoc.skip
+ """
+ }
Review Comment:
There are many similarities in this code snippet. You can probably refactor the moving part (different properties) in a variable (using the `if` branches) and call afterwards mvn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asolimando commented on a diff in pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
asolimando commented on code in PR #3254:
URL: https://github.com/apache/hive/pull/3254#discussion_r943246071
##########
Jenkinsfile:
##########
@@ -304,6 +304,53 @@ tar -xzf packaging/target/apache-hive-*-nightly-*-src.tar.gz
}
}
}
+ branches['sonar'] = {
+ executorNode {
+ if(env.CHANGE_BRANCH == 'master') {
+ stage('Prepare') {
+ loadWS();
+ }
+ stage('Sonar') {
+ withCredentials([string(credentialsId: 'sonar', variable: 'SONAR_TOKEN')]) {
+ sh """#!/bin/bash -e
+ sw java 11 && . /etc/profile.d/java.sh
+ export MAVEN_OPTS=-Xmx5G
+ mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar \
+ -Dsonar.organization=apache \
+ -Dsonar.projectKey=apache_hive \
+ -Dsonar.host.url=https://sonarcloud.io \
+ -Dsonar.branch.name=${CHANGE_BRANCH} \
+ -DskipTests -Dit.skipTests -Dmaven.javadoc.skip
+ """
+ }
+ }
+ } else if(env.CHANGE_ID) {
+ stage('Prepare') {
+ loadWS();
+ }
+ stage('Sonar') {
+ withCredentials([string(credentialsId: 'sonar', variable: 'SONAR_TOKEN')]) {
+ sh """#!/bin/bash -e
+ sw java 11 && . /etc/profile.d/java.sh
+ export MAVEN_OPTS=-Xmx5G
+ mvn org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar \
+ -Dsonar.organization=apache \
+ -Dsonar.projectKey=apache_hive \
+ -Dsonar.host.url=https://sonarcloud.io \
+ -Dsonar.pullrequest.github.repository=apache/hive \
+ -Dsonar.pullrequest.key=${CHANGE_ID} \
+ -Dsonar.pullrequest.branch=${CHANGE_BRANCH} \
+ -Dsonar.pullrequest.base=${CHANGE_TARGET} \
+ -Dsonar.pullrequest.provider=GitHub \
+ -DskipTests -Dit.skipTests -Dmaven.javadoc.skip
+ """
+ }
Review Comment:
I have unified the common pieces and created a parameterized function to run sonar analysis, current run is still on-going but the sonar task has already successfully completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a diff in pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on code in PR #3254:
URL: https://github.com/apache/hive/pull/3254#discussion_r880514334
##########
Jenkinsfile:
##########
@@ -245,6 +245,21 @@ fi
buildHive("install -Dtest=noMatches")
}
checkPrHead()
+ stage('Sonar') {
+ if(env.CHANGE_BRANCH == 'master-sonar_analysis') {
Review Comment:
I think this should be changed to master - or not?
##########
Jenkinsfile:
##########
@@ -245,6 +245,21 @@ fi
buildHive("install -Dtest=noMatches")
}
checkPrHead()
+ stage('Sonar') {
+ if(env.CHANGE_BRANCH == 'master-sonar_analysis') {
+ withCredentials([string(credentialsId: 'sonar', variable: 'SONAR_TOKEN')]) {
Review Comment:
nice :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a diff in pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on code in PR #3254:
URL: https://github.com/apache/hive/pull/3254#discussion_r880513438
##########
Jenkinsfile:
##########
@@ -245,6 +245,21 @@ fi
buildHive("install -Dtest=noMatches")
}
checkPrHead()
+ stage('Sonar') {
Review Comment:
in its current form; this adds a 36m long linear phase to the build; which means all builds will take that much longer
Can you move this over to the fan-out phase when tests are being executed? (you could do something like `nightly-check`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1143408741
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3254)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1211695071
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3254)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [103 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [33 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [1764 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asolimando commented on pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
asolimando commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1143867392
@kgyrtkirk can you have another look? At the moment we are analyzing PRs and the master branch, I don't think we need to support labels or anything, because whatever change we want to make has to pass through a PR, we will spot eventual issues before merging, so I think we can stick with just analyzing the master branch. WDYT?
PS: I have updated the title of the Jira ticket, the message of the first commit is outdated, I am not amending it because otherwise it will trigger CI again for nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1206641629
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3254)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [102 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [33 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [1722 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1200542612
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1205561532
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3254)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [102 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [33 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [1722 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asolimando commented on pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch and PRs
Posted by GitBox <gi...@apache.org>.
asolimando commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1212000463
The test failures are due to flakyness and not related at all to the present PR, I am not going to run tests again to avoid wasting resources, I hope that's OK with you @zabetak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asolimando commented on a diff in pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch
Posted by GitBox <gi...@apache.org>.
asolimando commented on code in PR #3254:
URL: https://github.com/apache/hive/pull/3254#discussion_r880607534
##########
Jenkinsfile:
##########
@@ -245,6 +245,21 @@ fi
buildHive("install -Dtest=noMatches")
}
checkPrHead()
+ stage('Sonar') {
+ if(env.CHANGE_BRANCH == 'master-sonar_analysis') {
Review Comment:
Yes, it's just for testing in CI, it's in the "change before merge" TODO list in the PR description, I will have a final commit with those fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3254: HIVE-26196: Integrate Sonar analysis for the master branch
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1143673904
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3254)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3254&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3254&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3254&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org