You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/09/22 01:58:28 UTC
[kudu-CR] [consensus] don't crash in RaftConsensus::ChangeConfig
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8124
Change subject: [consensus] don't crash in RaftConsensus::ChangeConfig
......................................................................
[consensus] don't crash in RaftConsensus::ChangeConfig
Don't crash if ReplicateConfigChangeUnlocked() returns an error.
Instead, just return corresponding error to the caller. This is
to avoid crashing a tablet server if an invalid Raft configuration is
passed to ChangeConfig() RPC with ChangeConfigRequestPB parameter.
Also, use move semantics for all parameters of the
RaftConsensus::ReplicateConfigChangeUnlocked() method.
Change-Id: Ieac3692adae029d098fea254badf2c53c6ac4fd8
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 11 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/8124/1
--
To view, visit http://gerrit.cloudera.org:8080/8124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieac3692adae029d098fea254badf2c53c6ac4fd8
Gerrit-Change-Number: 8124
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] don't crash in RaftConsensus::ChangeConfig
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8124 )
Change subject: [consensus] don't crash in RaftConsensus::ChangeConfig
......................................................................
[consensus] don't crash in RaftConsensus::ChangeConfig
Don't crash if ReplicateConfigChangeUnlocked() returns an error.
Instead, just return corresponding error to the caller. This is
to avoid crashing a tablet server if an invalid Raft configuration is
passed to ChangeConfig() RPC with ChangeConfigRequestPB parameter.
Also, use move semantics for all parameters of the
RaftConsensus::ReplicateConfigChangeUnlocked() method.
Change-Id: Ieac3692adae029d098fea254badf2c53c6ac4fd8
Reviewed-on: http://gerrit.cloudera.org:8080/8124
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
2 files changed, 11 insertions(+), 13 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieac3692adae029d098fea254badf2c53c6ac4fd8
Gerrit-Change-Number: 8124
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus] don't crash in RaftConsensus::ChangeConfig
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8124 )
Change subject: [consensus] don't crash in RaftConsensus::ChangeConfig
......................................................................
Patch Set 2: Code-Review+2
Carrying over Mike's +2 fro PS1
--
To view, visit http://gerrit.cloudera.org:8080/8124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieac3692adae029d098fea254badf2c53c6ac4fd8
Gerrit-Change-Number: 8124
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 25 Sep 2017 23:24:42 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] don't crash in RaftConsensus::ChangeConfig
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8124 )
Change subject: [consensus] don't crash in RaftConsensus::ChangeConfig
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieac3692adae029d098fea254badf2c53c6ac4fd8
Gerrit-Change-Number: 8124
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 25 Sep 2017 22:11:56 +0000
Gerrit-HasComments: No