You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/02 05:39:59 UTC

[GitHub] [flink-ml] yunfengzhou-hub opened a new pull request, #170: [FLINK-29843] Improve Euclidean distance accuracy

yunfengzhou-hub opened a new pull request, #170:
URL: https://github.com/apache/flink-ml/pull/170

   ## What is the purpose of the change
   
   This PR fixes the bug that `EuclideanDistanceMeasure.distance(...)` method might return NaN values due to loss of data accuracy during computation by modifying the implementation of this method.
   
   ## Brief change log
   
     - Uses an implementation with higher data accuracy without getting negative values in `EuclideanDistanceMeasure.distance(...)` method
     - Adds corresponding test cases.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 merged pull request #170: [FLINK-29843] Avoid negative euclidean distance square

Posted by GitBox <gi...@apache.org>.
zhipeng93 merged PR #170:
URL: https://github.com/apache/flink-ml/pull/170


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] zhipeng93 commented on pull request #170: [FLINK-29843] Avoid negative euclidean distance square

Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on PR #170:
URL: https://github.com/apache/flink-ml/pull/170#issuecomment-1299674421

   Thanks for the PR. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org