You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/07/01 20:52:38 UTC

Re: Review Request 22857: Made sure Cluster::Masters::start() returns when the Master is ready for incoming requests. i.e., after it has finished executing _recover().

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22857/
-----------------------------------------------------------

(Updated July 1, 2014, 11:52 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Add reviewers


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/tests/cluster.hpp 1c96ee7d27d1f2f277bc4617f9e17092460d7191 

Diff: https://reviews.apache.org/r/22857/diff/


Testing (updated)
-------

make check.


Thanks,

Jiang Yan Xu


Re: Review Request 22857: Made sure Cluster::Masters::start() returns when the Master is ready for incoming requests. i.e., after it has finished executing _recover().

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22857/#review47127
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 1, 2014, 6:52 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22857/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 6:52 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.hpp 1c96ee7d27d1f2f277bc4617f9e17092460d7191 
> 
> Diff: https://reviews.apache.org/r/22857/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request 22857: Made sure Cluster::Masters::start() returns when the Master is ready for incoming requests. i.e., after it has finished executing _recover().

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22857/#review47135
-----------------------------------------------------------


Patch looks great!

Reviews applied: [22857]

All tests passed.

- Mesos ReviewBot


On July 1, 2014, 6:52 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22857/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 6:52 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/cluster.hpp 1c96ee7d27d1f2f277bc4617f9e17092460d7191 
> 
> Diff: https://reviews.apache.org/r/22857/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>