You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2025/12/19 09:36:34 UTC
[PR] Correct the getObjectPathFromBinary method in ObjectTypeUtils [iotdb]
JackieTien97 opened a new pull request, #16934:
URL: https://github.com/apache/iotdb/pull/16934
This pull request refactors methods related to retrieving file paths from `Binary` objects in the `ObjectTypeUtils` class to simplify and clarify their usage. The main focus is to consolidate redundant methods and update their usage throughout the codebase.
**Refactoring of file path retrieval methods:**
* The `getObjectPathFromBinary(Binary binary)` method now delegates to a new overloaded method that accepts a `needTempFile` parameter, improving code clarity and reducing duplication.
* The previously used `getNullableObjectPathFromBinary` method has been removed in favor of the new `getObjectPathFromBinary(Binary binary, boolean needTempFile)` method, streamlining the API.
* All internal usages, such as in `deleteObjectPathFromBinary`, have been updated to use the new method signature.
**Minor cleanup:**
* Removed an unused import of `TSFileConfig` from the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct the getObjectPathFromBinary method in ObjectTypeUtils [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16934:
URL: https://github.com/apache/iotdb/pull/16934#issuecomment-3674554806
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/16934?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 39.16%. Comparing base ([`ca26dd3`](https://app.codecov.io/gh/apache/iotdb/commit/ca26dd36ce413ad05571971379ba21f2328b47ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9c9a5eb`](https://app.codecov.io/gh/apache/iotdb/commit/9c9a5ebdfd850a1c066926d86774cf4051a381a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16934 +/- ##
=========================================
Coverage 39.16% 39.16%
Complexity 212 212
=========================================
Files 5048 5048
Lines 334961 334959 -2
Branches 42685 42685
=========================================
+ Hits 131179 131191 +12
+ Misses 203782 203768 -14
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/16934?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct the getObjectPathFromBinary method in ObjectTypeUtils [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #16934:
URL: https://github.com/apache/iotdb/pull/16934#issuecomment-3674322465
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16934) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16934&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16934&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=16934&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16934&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16934&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16934)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct the getObjectPathFromBinary method in ObjectTypeUtils [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #16934:
URL: https://github.com/apache/iotdb/pull/16934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org