[jira] [Commented] (HBASE-10814) RpcClient: some calls can get stuck when connection is closing

["Nick Dimiduk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945256#comment-13945256 ] 

Nick Dimiduk commented on HBASE-10814:
--------------------------------------

Looks good to me, [~nkeywal]. Do you want to do something stronger than assert here? Most folks won't run with -ea in prod. Maybe throw explicitly?

{noformat}
+        assert !expectedCall || call.done; // if we received something, we took care of it.
{noformat}

> RpcClient: some calls can get stuck when connection is closing
> --------------------------------------------------------------
>
>                 Key: HBASE-10814
>                 URL: https://issues.apache.org/jira/browse/HBASE-10814
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.99.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Critical
>             Fix For: 0.99.0
>
>         Attachments: 10814.v1.patch
>
>
> On some paths with exception, the call can be removed from the list w/o being set to done. Hence it won't be cleaned on connection close, and the client will keep waiting.



--
This message was sent by Atlassian JIRA
(v6.2#6252)