You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2026/02/27 16:35:51 UTC

[kudu-CR] KUDU-3743 Add table statistics to Python client

Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24051


Change subject: KUDU-3743 Add table statistics to Python client
......................................................................

KUDU-3743 Add table statistics to Python client

Wrap KuduTableStatistics and KuduClient::GetTableStatistics in the
Python client, exposing on_disk_size, live_row_count,
on_disk_size_limit, and live_row_count_limit as read-only properties on
a new TableStatistics class.

Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 213 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/24051/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 2: Verified+1

unrelated test failures:
debug: master-stress-test.2, security-itest.0
release: master_authz-itest.4
tsan: org.apache.kudu.spark.kudu.DefaultSourceTest, org.apache.kudu.client.TestSecurity


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 17:31:19 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2365/


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 16:31:18 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Mar 2026 12:58:50 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Zoltan Martonka, Gabriella Lotz, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24051

to look at the new patch set (#2).

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................

KUDU-3743 Add table statistics to Python client

Wrap KuduTableStatistics and KuduClient::GetTableStatistics in the
Python client, exposing on_disk_size, live_row_count,
on_disk_size_limit, and live_row_count_limit as read-only properties on
a new TableStatistics class.

Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 212 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/24051/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 1: -Verified

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2305/


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Feb 2026 09:58:20 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24051/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

http://gerrit.cloudera.org:8080/#/c/24051/1/python/kudu/tests/test_client.py@1277
PS1, Line 1277:     def test_on_disk_size_is_valid(self):
              :         stats = self.client.get_table_statistics(self.ex_table)
              :         # -1 means unsupported; any non-negative value is also valid.
              :         self.assertGreaterEqual(stats.on_disk_size, -1)
              : 
              :     def test_live_row_count_is_valid(self):
              :         stats = self.client.get_table_statistics(self.ex_table)
              :         self.assertGreaterEqual(stats.live_row_count, -1)
> Since test_live_row_count_reflects_written_data already assumes the test Ku
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 16:31:41 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2304/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 27 Feb 2026 20:28:04 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................

KUDU-3743 Add table statistics to Python client

Wrap KuduTableStatistics and KuduClient::GetTableStatistics in the
Python client, exposing on_disk_size, live_row_count,
on_disk_size_limit, and live_row_count_limit as read-only properties on
a new TableStatistics class.

Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Reviewed-on: http://gerrit.cloudera.org:8080/24051
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 212 insertions(+), 0 deletions(-)

Approvals:
  Marton Greber: Verified
  Alexey Serbin: Looks good to me, approved
  Gabriella Lotz: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2365/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 17:15:50 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 1: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/2305/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Feb 2026 10:42:08 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Sat, 14 Mar 2026 03:57:49 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2304/


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 27 Feb 2026 16:35:59 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24051/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

http://gerrit.cloudera.org:8080/#/c/24051/1/python/kudu/tests/test_client.py@1277
PS1, Line 1277:     def test_on_disk_size_is_valid(self):
              :         stats = self.client.get_table_statistics(self.ex_table)
              :         # -1 means unsupported; any non-negative value is also valid.
              :         self.assertGreaterEqual(stats.on_disk_size, -1)
              : 
              :     def test_live_row_count_is_valid(self):
              :         stats = self.client.get_table_statistics(self.ex_table)
              :         self.assertGreaterEqual(stats.live_row_count, -1)
Since test_live_row_count_reflects_written_data already assumes the test Kudu cluster supports live row count and disk size stats, would it make sense to make the comparison more strict, use the reference value of 0?



-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Mar 2026 04:31:46 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3743 Add table statistics to Python client

Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )

Change subject: KUDU-3743 Add table statistics to Python client
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7
Gerrit-Change-Number: 24051
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 12:44:52 +0000
Gerrit-HasComments: No