You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/12/19 09:47:03 UTC
[GitHub] [rocketmq-spring] zhangjidi2016 opened a new pull request #206:
[ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer
zhangjidi2016 opened a new pull request #206: [ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer
URL: https://github.com/apache/rocketmq-spring/pull/206
## What is the purpose of the change
Fix the Infinite loop in DefaultRocketMQListenerContainer
## Brief changelog
Adjust the getMessageType method
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] vongosling merged pull request #206: [ISSUE #151]
Fix the Infinite loop in DefaultRocketMQListenerContainer
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #206: [ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer
URL: https://github.com/apache/rocketmq-spring/pull/206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] zongtanghu commented on issue #206: [ISSUE #151]
Fix the Infinite loop in DefaultRocketMQListenerContainer
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #206: [ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer
URL: https://github.com/apache/rocketmq-spring/pull/206#issuecomment-568145562
I suggest this pr can be merged after December 31.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] zongtanghu removed a comment on issue #206:
[ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer
Posted by GitBox <gi...@apache.org>.
zongtanghu removed a comment on issue #206: [ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer
URL: https://github.com/apache/rocketmq-spring/pull/206#issuecomment-568145562
I suggest this pr can be merged after December 31.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] zongtanghu commented on issue #206: [ISSUE #151]
Fix the Infinite loop in DefaultRocketMQListenerContainer
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #206: [ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer
URL: https://github.com/apache/rocketmq-spring/pull/206#issuecomment-568145468
I suggest this pr can be merged after December 31.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] vongosling commented on issue #206: [ISSUE #151]
Fix the Infinite loop in DefaultRocketMQListenerContainer
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #206: [ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer
URL: https://github.com/apache/rocketmq-spring/pull/206#issuecomment-568339422
@zhangjidi2016 Great work, adding some related unit test for your pr could be convinced for a reviewer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] zhangjidi2016 commented on issue #206: [ISSUE
#151] Fix the Infinite loop in DefaultRocketMQListenerContainer
Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on issue #206: [ISSUE #151] Fix the Infinite loop in DefaultRocketMQListenerContainer
URL: https://github.com/apache/rocketmq-spring/pull/206#issuecomment-570105625
> @zhangjidi2016 Great work, adding some related unit test for your pr could be convinced for a reviewer
OK，The DefaultRocketMQListenerContainerTest class has already existed the unit test for getMessageType method， and has passed the unit test after submit this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services