You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/09 05:00:56 UTC
[GitHub] [iotdb] ericpai commented on a diff in pull request #6197: ISSUE-#5885
ericpai commented on code in PR #6197:
URL: https://github.com/apache/iotdb/pull/6197#discussion_r893071377
##########
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileResource.java:
##########
@@ -848,8 +848,10 @@ public TsFileResource createHardlink() {
return newResource;
}
- public synchronized void setModFile(ModificationFile modFile) {
- this.modFile = modFile;
+ public void setModFile(ModificationFile modFile) {
Review Comment:
Why we need to change this. IMO they have the same meaning, just locking the object itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org