You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ahmedabu98 (via GitHub)" <gi...@apache.org> on 2023/05/24 20:40:34 UTC
[GitHub] [beam] ahmedabu98 opened a new pull request, #26879: [BQ Storage] Allow using optional minutes in timestamp offset
ahmedabu98 opened a new pull request, #26879:
URL: https://github.com/apache/beam/pull/26879
Fixes #26796
We currently use DateTimeFormatterBuilder's appendOffsetId() to construct our timestamp pattern. However, appendOffsetId() requires minutes. These changes replace that with a custom pattern `"+HH:mm:ss"` that requires hours but all else is optional. This matches the examples we see in BQ documentation: https://cloud.google.com/bigquery/docs/reference/standard-sql/timestamp_functions#timestamp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26879: [BQ Storage] Allow using optional minutes in timestamp offset
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26879:
URL: https://github.com/apache/beam/pull/26879#issuecomment-1561979671
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #26879: [BQ Storage] Allow using optional minutes in timestamp offset
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #26879:
URL: https://github.com/apache/beam/pull/26879#issuecomment-1561897823
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26879: [BQ Storage] Allow using optional minutes in timestamp offset
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26879:
URL: https://github.com/apache/beam/pull/26879#issuecomment-1561899080
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26879: [BQ Storage] Allow using optional minutes in timestamp offset
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26879:
URL: https://github.com/apache/beam/pull/26879#issuecomment-1562146310
```
Caused by: java.lang.IllegalArgumentException: Invalid zone offset pattern: +HH:mm:ss
at java.time.format.DateTimeFormatterBuilder$OffsetIdPrinterParser.checkPattern(DateTimeFormatterBuilder.java:3341)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26879: [BQ Storage] Allow using optional minutes in timestamp offset
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26879:
URL: https://github.com/apache/beam/pull/26879#issuecomment-1563022127
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #26879: [BQ Storage] Allow using optional minutes in timestamp offset
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26879:
URL: https://github.com/apache/beam/pull/26879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org