You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2012/05/16 06:08:28 UTC
[jira] [Created] (HBASE-6013) Polish sharp edges from CopyTable
Jonathan Hsieh created HBASE-6013:
-------------------------------------
Summary: Polish sharp edges from CopyTable
Key: HBASE-6013
URL: https://issues.apache.org/jira/browse/HBASE-6013
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.92.1, 0.90.6, 0.96.0
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-6013:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.94.1
0.96.0
0.92.2
0.90.7
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
committed to 0.90/0.92/0.94/0.96. Thanks for looking at it JD.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.96.0, 0.94.1
>
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-6013:
----------------------------------
Attachment: hbase-6013.patch
tested in live cluster against 0.94.0rc3 brach.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278358#comment-13278358 ]
Jean-Daniel Cryans commented on HBASE-6013:
-------------------------------------------
Like I said, it used to be useful but for the sake of being careful I'd just remove from 0.92 and on.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276487#comment-13276487 ]
Hadoop QA commented on HBASE-6013:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12527566/hbase-6013.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1884//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1884//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1884//console
This message is automatically generated.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-6013:
----------------------------------
Status: Patch Available (was: Open)
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.92.1, 0.90.6, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278431#comment-13278431 ]
Jonathan Hsieh commented on HBASE-6013:
---------------------------------------
Ok, I'm going to submit the current patches since they are essentially the same, and then file a separate issues to remove rs.* (0.92+ removing) and change peer.adr to peer.addr (0.90/0.92/0.94 deprecating with 0.96 removing) since they only get applied to particular branches.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283270#comment-13283270 ]
Hudson commented on HBASE-6013:
-------------------------------
Integrated in HBase-0.92-security #108 (See [https://builds.apache.org/job/HBase-0.92-security/108/])
HBASE-6013 Polish sharp edges from CopyTable (Revision 1339931)
Result = FAILURE
jmhsieh :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/mapreduce/CopyTable.java
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.96.0, 0.94.1
>
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277602#comment-13277602 ]
Jonathan Hsieh commented on HBASE-6013:
---------------------------------------
I will commit tomorrow to all affected versions unless I hear otherwise.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278470#comment-13278470 ]
Hudson commented on HBASE-6013:
-------------------------------
Integrated in HBase-TRUNK #2897 (See [https://builds.apache.org/job/HBase-TRUNK/2897/])
HBASE-6013 Polish sharp edges from CopyTable (Revision 1339929)
Result = FAILURE
jmhsieh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CopyTable.java
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.96.0, 0.94.1
>
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-6013:
----------------------------------
Issue Type: Improvement (was: Bug)
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278351#comment-13278351 ]
Jonathan Hsieh commented on HBASE-6013:
---------------------------------------
JD - can I just remove the rs.* from all >= 0.90 versions? Is there any legitimate use for it?
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278336#comment-13278336 ]
Jean-Daniel Cryans commented on HBASE-6013:
-------------------------------------------
bq. Do you want me to change the spelling of --peer.adr? If we do that I'd still keep the old spelling around for compatibility's sake.
That's what I was trying to say.
bq. I wasn't sure if the rs.class stuff was needed still – sounds like we can file a follow on issue to get rid of that?
Or change this jira's scope, whatever works for you.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-6013:
----------------------------------
Attachment: hbase-6013-92.patch
A 0.92 version that also applies to 0.90.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278749#comment-13278749 ]
Hudson commented on HBASE-6013:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #9 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/9/])
HBASE-6013 Polish sharp edges from CopyTable (Revision 1339929)
Result = FAILURE
jmhsieh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CopyTable.java
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.96.0, 0.94.1
>
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278554#comment-13278554 ]
Hudson commented on HBASE-6013:
-------------------------------
Integrated in HBase-0.92 #411 (See [https://builds.apache.org/job/HBase-0.92/411/])
HBASE-6013 Polish sharp edges from CopyTable (Revision 1339931)
Result = FAILURE
jmhsieh :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/mapreduce/CopyTable.java
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.96.0, 0.94.1
>
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-6013:
----------------------------------
Comment: was deleted
(was: -1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12527945/hbase-6013-92.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1921//console
This message is automatically generated.)
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278332#comment-13278332 ]
Jonathan Hsieh commented on HBASE-6013:
---------------------------------------
JD, I wasn't considering --peer.adr as a typo. I didn't modify the --peer.adr arguments or any of the others -- I left them as is. The code I added only reports an error if the user does a typo like using --peer.addr (two d's) or -peer.adr (single -).
Previously these kinds of typos would continue "working" silently without reporting errors and end up using the default zk quorum or copying full tables when different behavior was expected.
Do you want me to change the spelling of --peer.adr? If we do that I'd still keep the old spelling around for compatibility's sake.
I wasn't sure if the rs.class stuff was needed still -- sounds like we can file a follow on issue to get rid of that?
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-6013.
--------------------------------
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.7, 0.92.2, 0.94.1, 0.96.0
>
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278355#comment-13278355 ]
Hadoop QA commented on HBASE-6013:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12527945/hbase-6013-92.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1921//console
This message is automatically generated.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013-92.patch, hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6013) Polish sharp edges from CopyTable
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278295#comment-13278295 ]
Jean-Daniel Cryans commented on HBASE-6013:
-------------------------------------------
Thanks for looking at this Jon, regarding the "adr" typo I have a big issue when the words in French are the same in English except for a few different letters. For example, example is exemple, address is adresse, marriage is mariage (that one almost put me in trouble last year), etc
Anyways, I see that you didn't change the way peer.addr is handled but it seemed important to you from the description. Should we just handle both but show "peer.addr" in the help? I'm thinking we could also remove rs.class and such, it used to be useful but not anymore.
> Polish sharp edges from CopyTable
> ---------------------------------
>
> Key: HBASE-6013
> URL: https://issues.apache.org/jira/browse/HBASE-6013
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-6013.patch
>
>
> CopyTable doesn't report errors when invalid arguments are specified. For example, having a typo in --peer.adr (such as --peer.addr or -peer.adr) silently uses the default cluster and does a same-cluster copy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira